Skip to content

Does operator-sdk build support ppc64le #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vincent-pli opened this issue Jun 25, 2019 · 5 comments
Closed

Does operator-sdk build support ppc64le #1595

vincent-pli opened this issue Jun 25, 2019 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vincent-pli
Copy link
Contributor

I mean could operator-sdk build build go binary for ppc64le, local build or cross-compile.
BTW, what about s390x

@vincent-pli
Copy link
Contributor Author

Hi folks, I checked the code in cmd/operator-sdk/build/cmd.go, see this:

	goBuildEnv := append(os.Environ(), "GOOS=linux", "GOARCH=amd64")

Could we remove the "GOARCH=amd64"?

@joelanford
Copy link
Member

I think we should support other architectures, but I think we should be careful how we do it. As the code currently stands, it will always automatically cross-compile to amd64 even when run from non-amd64 machines.

Probably the best way to handle this would be to check if GOARCH is explicitly set. If it is, use it, and if it isn't keep the default of amd64.

Would that work for you? If so, you would be interested in submitting a PR with that patch?

@joelanford joelanford self-assigned this Jun 26, 2019
@joelanford joelanford added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 26, 2019
@vincent-pli
Copy link
Contributor Author

@joelanford
Sure, I'm glad to help on this issue

@joelanford
Copy link
Member

Thanks @vincent-pli

Closed by #1605

@chenzhiwei
Copy link

I am using this place to store operator-sdk ppc64le binary.

operator-sdk.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants