Expose an EventRecorder to the handler to allow recording custom events

[andersjanmyr]

In order to record events for the operator it would be beneficial if the SDK would expose the EventRecorder interface.

Example (from https://github.com/kubernetes/sample-controller/blob/master/controller.go#L103-L107)

eventBroadcaster := record.NewBroadcaster()
eventBroadcaster.StartLogging(glog.Infof)
eventBroadcaster.StartRecordingToSink(&typedcorev1.EventSinkImpl{Interface: kubeclientset.CoreV1().Events("")})
recorder := eventBroadcaster.NewRecorder(scheme.Scheme, corev1.EventSource{Component: controllerAgentName})

I'd be happy to work on this, but I would like your feedback as to how you would like to expose the recorder to the handler.

This may be related to #146 .

[xiang90]

@andersjanmyr

What do you want to record? The incoming events and the actions to take or some customized stuff? If it is the former, we can have a default implementation that does it for the users. The user only need to enable it like sdk.EnableAutoRecording(). If it is the latter, we do need to have a wrapper around the native kube api.

[andersjanmyr]

@xiang90 I was thinking of the latter, custom events. I'm not sure that all the events that all incoming events will be interesting and I will definitely need to modify the events as they come in.

[hasbro17]

@andersjanmyr This issue depends on #169
The current APIs exposed to the handler are all package level and depend on global states(scheme, config, clientsets). Any new API or client that's exposed to the handler would be adding to that state.

We're currently working on removing all global state by defining the necessary objects and interfaces. Once that's done we can expose the correct API to the Handler to record its custom events.

[shawn-hurley]

You can now access the event recorder from the manager GetRecorder(name string) record.EventRecorder

If you feel this should not be closed please re-open.