From 5c5a5315ae8094ed580c3809245486af514db6b2 Mon Sep 17 00:00:00 2001 From: Matt Carroll Date: Mon, 5 Oct 2020 16:37:50 -0700 Subject: [PATCH 1/2] fix(project config manager): Don't log an error when not initialized with datafile --- .../lib/core/project_config/project_config_manager.js | 9 +++++++-- .../core/project_config/project_config_manager.tests.js | 7 +++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/packages/optimizely-sdk/lib/core/project_config/project_config_manager.js b/packages/optimizely-sdk/lib/core/project_config/project_config_manager.js index e3a6242f8..44aabf220 100644 --- a/packages/optimizely-sdk/lib/core/project_config/project_config_manager.js +++ b/packages/optimizely-sdk/lib/core/project_config/project_config_manager.js @@ -91,8 +91,13 @@ ProjectConfigManager.prototype.__initialize = function(config) { return; } - var handleNewDatafileException = this.__handleNewDatafile(config.datafile); - if (handleNewDatafileException) { + let handleNewDatafileException; + if (config.datafile) { + handleNewDatafileException = this.__handleNewDatafile(config.datafile); + if (handleNewDatafileException) { + this.__configObj = null; + } + } else { this.__configObj = null; } diff --git a/packages/optimizely-sdk/lib/core/project_config/project_config_manager.tests.js b/packages/optimizely-sdk/lib/core/project_config/project_config_manager.tests.js index 359a94599..c9d44b03c 100644 --- a/packages/optimizely-sdk/lib/core/project_config/project_config_manager.tests.js +++ b/packages/optimizely-sdk/lib/core/project_config/project_config_manager.tests.js @@ -347,6 +347,13 @@ describe('lib/core/project_config/project_config_manager', function() { manager.stop(); sinon.assert.calledOnce(datafileManager.HttpPollingDatafileManager.getCall(0).returnValue.stop); }); + + it('does not log an error message', function() { + projectConfigManager.createProjectConfigManager({ + sdkKey: '12345', + }); + sinon.assert.notCalled(stubLogHandler.log); + }); }); describe('when constructed with sdkKey and with a valid datafile object', function() { From 8ffd5d9e401ff2f86a39a14ac8dd97626009cc63 Mon Sep 17 00:00:00 2001 From: Matt Carroll Date: Tue, 6 Oct 2020 09:06:23 -0700 Subject: [PATCH 2/2] Add changelog entry --- packages/optimizely-sdk/CHANGELOG.MD | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/optimizely-sdk/CHANGELOG.MD b/packages/optimizely-sdk/CHANGELOG.MD index 8f95d63f8..6f3bab164 100644 --- a/packages/optimizely-sdk/CHANGELOG.MD +++ b/packages/optimizely-sdk/CHANGELOG.MD @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Bug fixes - Fixed return type of `getAllFeatureVariables` method and `dispatchEvent ` method signature of `EventDispatcher` interface in TypeScript type definitions ([#576](https://github.com/optimizely/javascript-sdk/pull/576)) +- Don't log an error message when initialized with `sdkKey`, but no `datafile` ([#589](https://github.com/optimizely/javascript-sdk/pull/589)) ## [4.3.1] - October 5, 2020