From 274bb2da989ffb55a9f91bf4f214f7434668d258 Mon Sep 17 00:00:00 2001 From: Md Junaed Hossain <169046794+junaed-optimizely@users.noreply.github.com> Date: Wed, 29 Jan 2025 19:27:31 +0600 Subject: [PATCH] [FSSDK-11098] using readyPromise instead of onReady --- lib/index.browser.tests.js | 4 ++++ lib/optimizely_user_context/index.ts | 6 ++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/index.browser.tests.js b/lib/index.browser.tests.js index e14b91463..115c337a7 100644 --- a/lib/index.browser.tests.js +++ b/lib/index.browser.tests.js @@ -584,6 +584,10 @@ describe('javascript-sdk (Browser)', function() { const fakeOptimizely = { onReady: () => Promise.resolve({ success: true }), identifyUser: sinon.stub().returns(), + isOdpIntegrated: () => true, + readyPromise: Promise.resolve({ + success: true, + }), }; const fakeErrorHandler = { handleError: function() {} }; diff --git a/lib/optimizely_user_context/index.ts b/lib/optimizely_user_context/index.ts index 0b689237a..b9939ae51 100644 --- a/lib/optimizely_user_context/index.ts +++ b/lib/optimizely_user_context/index.ts @@ -64,8 +64,10 @@ export default class OptimizelyUserContext implements IOptimizelyUserContext { this.forcedDecisionsMap = {}; if (shouldIdentifyUser) { - this.optimizely.onReady().then(({ success }) => { - if (success) { + // eslint-disable-next-line @typescript-eslint/ban-ts-comment + // @ts-ignore + optimizely.readyPromise.then(({ success }) => { + if (success && optimizely.isOdpIntegrated()) { this.identifyUser(); } });