-
Notifications
You must be signed in to change notification settings - Fork 1.7k
com.oracle.svm.core.annotate.* annotations in separate artifact #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think #1003 (comment) applies here as well. |
Hi @cstancu, I don't think I agree, as the 'provided' scope still gives a whole lot of extra dependencies in the project. If you only want to use the annotations to make your application work with GraalVM native-image, those other dependencies are not needed (and only introduce the risk of actually using them). What's your take on this? |
@Jurrie having |
@olpaw as my applictation progressed to be compatible with GraalVM's native-image, I also needed an |
I don't like to separate the annotations in a separate artifact because in an ideal world, it should not be necessary to use them to get an application running as a native image. Substitutions are a workaround until the substituted method itself is changed, which can be a lengthy process when it is in a third-party library. Note that you also should not use |
Hi @christianwimmer. I agree: in an ideal world, those annotations should not be necessary. But why is that an argument against splitting them out in a separate artifact? On top of that: this is not an ideal world. You can not argue with the fact that those artifacts are necessary now. They are meant to be used as a workaround, so why not ease the use by reducing the transitive dependencies? You also say that |
My project needs to include com.oracle.substratevm:svm:1.0.0-rc12, because I need to use the com.oracle.svm.core.annotate.* annotations. However, this transitively includes a whole lot of other dependencies. I don't need those. I can exclude them of course, but it would be cleaner if the annotations were in a different package with no transitive dependencies. Something like com.oracle.substratevm:svm-annotations.
The text was updated successfully, but these errors were encountered: