From 36d8417fdea9b6a02ebec0e9d945a30393f7b96c Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Mon, 25 Jan 2016 14:11:14 +0100 Subject: [PATCH 1/2] Making 'mx javadoc --unified' part of the gate --- mx.truffle/mx_truffle.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mx.truffle/mx_truffle.py b/mx.truffle/mx_truffle.py index 6771babf5bb3..8178165788d7 100644 --- a/mx.truffle/mx_truffle.py +++ b/mx.truffle/mx_truffle.py @@ -56,6 +56,8 @@ def sldebug(args): mx.run_java(vmArgs + ['-cp', mx.classpath("com.oracle.truffle.sl.tools"), "com.oracle.truffle.sl.tools.debug.SLREPL"] + slArgs) def _truffle_gate_runner(args, tasks): + with Task('Truffle Javadoc', tasks) as t: + if t: mx.javadoc(['--unified']) with Task('Truffle UnitTests', tasks) as t: if t: unittest(['--suite', 'truffle', '--enable-timing', '--verbose', '--fail-fast']) with Task('Truffle Signature Tests', tasks) as t: From 4a17feba37e58593c4491a8845bb511fe03c27dc Mon Sep 17 00:00:00 2001 From: Jaroslav Tulach Date: Mon, 25 Jan 2016 14:22:10 +0100 Subject: [PATCH 2/2] Fixing Javadoc warnings --- .../src/com/oracle/truffle/api/object/Layout.java | 2 +- .../src/com/oracle/truffle/api/object/Property.java | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/truffle/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Layout.java b/truffle/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Layout.java index ed292a06e06b..b1e5a8d82837 100644 --- a/truffle/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Layout.java +++ b/truffle/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Layout.java @@ -86,7 +86,7 @@ public static Layout createLayout() { * @param objectType that describes the object instance with this shape. * @param sharedData for language-specific use * @param id for language-specific use - * @return + * @return new instance of a shape */ public abstract Shape createShape(ObjectType objectType, Object sharedData, int id); diff --git a/truffle/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Property.java b/truffle/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Property.java index 3b387a2ea5af..0bb91062669f 100644 --- a/truffle/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Property.java +++ b/truffle/com.oracle.truffle.api.object/src/com/oracle/truffle/api/object/Property.java @@ -35,7 +35,10 @@ protected Property() { /** * Create a new property. * - * @param flags, for language-specific use + * @param key the key of the property + * @param location location of the property + * @param flags for language-specific use + * @return new instance of the property */ public static Property create(Object key, Location location, int flags) { return Layout.getFactory().createProperty(key, location, flags);