Skip to content

Commit 779711b

Browse files
author
Harvey Lowndes
committed
Review changes
1 parent 7a6ec05 commit 779711b

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

pkg/oci/ccm.go

+4
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,11 @@ import (
4747
const (
4848
// RateLimitQPSDefault sets a value for the default queries per second.
4949
RateLimitQPSDefault = 20.0
50+
<<<<<<< HEAD
5051
//RateLimitBucketDefault sets a value for the default token bucket burst size.
52+
=======
53+
// RateLimitBucketDefault sets a value for the default token bucket burst size.
54+
>>>>>>> Review changes
5155
RateLimitBucketDefault = 5
5256
)
5357

pkg/oci/client/compute.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ func (c *client) GetPrimaryVNICForInstance(ctx context.Context, compartmentID, i
129129
}
130130

131131
// TODO(apryde): Cache map[instanceID]primaryVNICID.
132-
vnic, err := c.getVNIC(ctx, *attachment.VnicId)
132+
vnic, err := c.GetVNIC(ctx, *attachment.VnicId)
133133
if err != nil {
134134
return nil, err
135135
}
@@ -181,7 +181,7 @@ func (c *client) GetInstanceByNodeName(ctx context.Context, compartmentID, vcnID
181181
continue
182182
}
183183

184-
vnic, err := c.getVNIC(ctx, *attachment.VnicId)
184+
vnic, err := c.GetVNIC(ctx, *attachment.VnicId)
185185
if err != nil {
186186
return nil, err
187187
}

pkg/oci/client/networking.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ type NetworkingInterface interface {
3232
UpdateSecurityList(ctx context.Context, request core.UpdateSecurityListRequest) (core.UpdateSecurityListResponse, error)
3333
}
3434

35-
func (c *client) getVNIC(ctx context.Context, id string) (*core.Vnic, error) {
35+
func (c *client) GetVNIC(ctx context.Context, id string) (*core.Vnic, error) {
3636
if !c.rateLimiter.Reader.TryAccept() {
37-
return nil, RateLimitError(false, "getVNIC")
37+
return nil, RateLimitError(false, "GetVNIC")
3838
}
3939

4040
resp, err := c.network.GetVnic(ctx, core.GetVnicRequest{

0 commit comments

Comments
 (0)