Skip to content

Commit f3201c2

Browse files
jbornemannprydie
authored andcommitted
Update example configuration to reflect new rate limiting feature, and security list specification (#240)
* Update example configuration to reflect new rate limiting feature, and security list specification * Misc. typos and inconsistencies
1 parent e11429b commit f3201c2

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

manifests/cloud-provider-example.yaml

+13
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,16 @@ loadBalancer:
5151
# Additionally requires the user to mange rules to allow
5252
# inbound traffic to load balancers.
5353
securityListManagementMode: All
54+
55+
# Optional specification of which security lists to modify per subnet. This does not apply if security list management is off.
56+
securityLists:
57+
ocid1.subnet.oc1.phx.aaaaaaaasa53hlkzk6nzksqfccegk2qnkxmphkblst3riclzs4rhwg7rg57q: ocid1.securitylist.oc1.iad.aaaaaaaaqti5jsfvyw6ejahh7r4okb2xbtuiuguswhs746mtahn72r7adt7q
58+
ocid1.subnet.oc1.phx.aaaaaaaahuxrgvs65iwdz7ekwgg3l5gyah7ww5klkwjcso74u3e4i64hvtvq: ocid1.securitylist.oc1.iad.aaaaaaaaqti5jsfvyw6ejahh7r4okb2xbtuiuguswhs746mtahn72r7adt7q
59+
60+
# Optional rate limit controls for accessing OCI API
61+
rateLimiter:
62+
rateLimitQPSRead: 20.0
63+
rateLimitBucketRead: 5
64+
rateLimitQPSWrite: 20.0
65+
rateLimitBucketWrite: 5
66+

pkg/oci/load_balancer_security_lists.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ type portSpec struct {
7272
}
7373

7474
type securityListManager interface {
75-
Update(ctx context.Context, lbSubnets []*core.Subnet, backendSubnets []*core.Subnet, sourceCIDRs []string, actaulPorts *portSpec, desiredPorts portSpec) error
75+
Update(ctx context.Context, lbSubnets []*core.Subnet, backendSubnets []*core.Subnet, sourceCIDRs []string, actualPorts *portSpec, desiredPorts portSpec) error
7676
Delete(ctx context.Context, lbSubnets []*core.Subnet, backendSubnets []*core.Subnet, actualPorts portSpec) error
7777
}
7878

@@ -229,7 +229,7 @@ func (s *defaultSecurityListManager) Update(ctx context.Context, lbSubnets []*co
229229
return s.updateBackendRules(ctx, lbSubnets, backendSubnets, actualPorts, desiredPorts)
230230
}
231231

232-
// Delete the security list rules associated with the listener & backends.
232+
// Delete the security list rules associated with the listener and backends.
233233
//
234234
// If the listener is nil, then only the egress rules from the LB's to the backends and the
235235
// ingress rules from the LB's to the backends will be cleaned up.

0 commit comments

Comments
 (0)