Skip to content

Config for Wercker release #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 6, 2018
Merged

Config for Wercker release #131

merged 15 commits into from
Feb 6, 2018

Conversation

garthy
Copy link
Member

@garthy garthy commented Jan 29, 2018

Also fixup Makefile target all to run tests and gofmt etc....

wercker.yml Outdated
- github-create-release:
token: $GITHUB_TOKEN
tag: $GITHUB_RELEASE_VERSION
title: Application $GITHUB_RELEASE_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Application. Was a mistake in the flexdriver yaml.

wercker.yml Outdated
file: $WERCKER_OUTPUT_DIR/oci-cloud-controller-manager-rbac.yaml
filename: oci-cloud-controller-manager-rbac.yaml


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cull trailing whitespace

Copy link
Member

@owainlewis owainlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Minor comments to address.

wercker.yml Outdated
filename: oci-cloud-controller-manager-rbac.yaml
content-type: text/yaml


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace cleanup

wercker.yml Outdated
- github-create-release:
token: $GITHUB_TOKEN
tag: $GITHUB_RELEASE_VERSION
title: Application $GITHUB_RELEASE_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title: Application $GITHUB_RELEASE_VERSION => title: $GITHUB_RELEASE_VERSION

wercker.yml Outdated

name: manifests
code: make manifests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead space will result in confusing merge differences for editors which auto prune trailing whitespace

- script:
name: set ENV vars
code: |
export VERSION=$(cat VERSION.txt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be

export VERSION=$(GITHUB_RELEASE_VERSION)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope it pick up the version

wercker.yml Outdated

- github-upload-asset:
token: $GITHUB_TOKEN
file: $WERCKER_OUTPUT_DIR/oci-cloud-controller-manager.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on previous experience I think this should be

file: oci-cloud-controller-manager.yaml

wercker.yml Outdated

- github-upload-asset:
token: $GITHUB_TOKEN
file: $WERCKER_OUTPUT_DIR/oci-cloud-controller-manager-rbac.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

$WERCKER_OUTPUT_DIR doesn't contain the previous pipelines input. That should be on the filesystem in current directory.

file: oci-cloud-controller-manager-rbac.yaml

@garthy garthy force-pushed the gb-wercker-release branch from d4d0149 to 703791d Compare February 6, 2018 10:42
@owainlewis owainlewis merged commit 9419964 into master Feb 6, 2018
@owainlewis owainlewis deleted the gb-wercker-release branch February 6, 2018 11:44
jbornemann pushed a commit that referenced this pull request Nov 26, 2018
l-technicore pushed a commit to l-technicore/oci-cloud-controller-manager that referenced this pull request Jun 14, 2022
…m task/OKE-15001 to internal

* commit '9ba9debf846335c324ec5d9963ff4efb6ee53f71':
  JIRA:task/OKE-15001 :: Introduce paging to ListVolumes, no limit, filter by display-name
ayushverma14 pushed a commit to ayushverma14/oci-cloud-controller-manager that referenced this pull request Jul 18, 2022
* Remove unused pod file
* Clean makefile to add version/build
* Add checks to all target, verbose build
* Configure for release
* Add release process and content type
* Move copy to step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants