Fix panic when no backends #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old node port rule in securityListManger.Update() rather than calling securityListManger.Delete() and then securityListManger.Update().
prydie
force-pushed
the
ap/backendset-panic
branch
from
3ca25e0 to
8c4cce7
Compare
owainlewis
reviewed
Mar 27, 2018
pkg/oci/load_balancer.go
Outdated
| "github.com/oracle/oci-go-sdk/core" | ||
| "github.com/oracle/oci-go-sdk/loadbalancer" | ||
| "github.com/pkg/errors" | ||
|
|
||
| api "k8s.io/api/core/v1" | ||
| v1 "k8s.io/api/core/v1" |
owainlewis
reviewed
Mar 27, 2018
pkg/oci/load_balancer.go
Outdated
| func (cp *CloudProvider) updateListener(ctx context.Context, lbID string, action *ListenerAction, ports portSpec, lbSubnets, nodeSubnets []*core.Subnet, sourceCIDRs []string) error { | ||
| var workRequestID string | ||
| var err error | ||
| l := action.Listener |
There was a problem hiding this comment.
I'd avoid using variable names that are this ambiguous in this context. Would prefer for clarity
listener := action.Listener
owainlewis
reviewed
Mar 27, 2018
| @@ -21,18 +21,20 @@ import ( | |||
| "github.com/oracle/oci-go-sdk/common" | |||
| "github.com/oracle/oci-go-sdk/core" | |||
|
|
|||
| "k8s.io/api/core/v1" | |||
| v1 "k8s.io/api/core/v1" | |||
There was a problem hiding this comment.
Minor: This is generally inconsistent in this PR. Sometimes it's qualified sometimes not. We don't need to qualify so suggest removing.
owainlewis
reviewed
Mar 27, 2018
pkg/oci/load_balancer_spec.go
Outdated
| if len(defaultSubnets) != 2 { | ||
| return LBSpec{}, errors.New("defualt subnets incorrectly configured") | ||
| return nil, errors.New("defualt subnets incorrectly configured") |
owainlewis
reviewed
Mar 27, 2018
pkg/oci/load_balancer_spec.go
Outdated
| } | ||
|
|
||
| func getBackends(nodes []*v1.Node, nodePort int32) []loadbalancer.BackendDetails { | ||
| if len(nodes) < 1 { |
owainlewis
suggested changes
Mar 27, 2018
prydie
force-pushed
the
ap/backendset-panic
branch
from
d6c57e6 to
36b38a1
Compare
prydie
force-pushed
the
ap/backendset-panic
branch
from
36b38a1 to
121d2c3
Compare
|
@owainlewis ready for a final review and merge. |
owainlewis
approved these changes
Mar 28, 2018
ayushverma14
pushed a commit
to ayushverma14/oci-cloud-controller-manager
that referenced
this pull request
Jul 18, 2022
* Refactor LBSpec to derive state up-front * Fix panic when no backends * Refactor security list manager to use portSpec * Remove old node port rule in Update() * Remove old node port rule in securityListManger.Update() rather than
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #67 and #152