Fixed bug when binding OUT a NULL boolean value (#119).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -13,6 +13,9 @@ oracledb 1.2.2 (TBD)
 Thin Mode Changes
 +++++++++++++++++
 
+#)  Fixed bug when binding OUT a NULL boolean value.
+    (`issue 119 <https://github.com/oracle/python-oracledb/issues/119>`__).
+
 Thick Mode Changes
 ++++++++++++++++++
 

src/oracledb/impl/thin/messages.pyx

@@ -1,5 +1,5 @@
 #------------------------------------------------------------------------------
-# Copyright (c) 2020, 2022, Oracle and/or its affiliates.
+# Copyright (c) 2020, 2023, Oracle and/or its affiliates.
 #
 # This software is dual-licensed to you under the Universal Permissive License
 # (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
@@ -615,7 +615,9 @@ cdef class MessageWithData(Message):
                               name=var_impl.dbtype.name)
         if not self.in_fetch:
             buf.read_sb4(&actual_num_bytes)
-            if actual_num_bytes != 0 and column_value is not None:
+            if actual_num_bytes < 0 and column_value is False:
+                column_value = None
+            elif actual_num_bytes != 0 and column_value is not None:
                 unit_type = "bytes" if isinstance(column_value, bytes) \
                             else "characters"
                 errors._raise_err(errors.ERR_COLUMN_TRUNCATED,

tests/sql/create_schema.sql

@@ -1,5 +1,5 @@
 /*-----------------------------------------------------------------------------
- * Copyright (c) 2020, 2022, Oracle and/or its affiliates.
+ * Copyright (c) 2020, 2023, Oracle and/or its affiliates.
  *
  * This software is dual-licensed to you under the Universal Permissive License
  * (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
@@ -968,6 +968,9 @@ create or replace package &main_user..pkg_TestBooleans as
         a_Value                         udt_BooleanList
     ) return number;
 
+    function TestOutValueNull
+    return boolean;
+
     procedure TestOutArrays (
         a_NumElements                   number,
         a_Value                         out nocopy udt_BooleanList
@@ -1011,6 +1014,12 @@ create or replace package body &main_user..pkg_TestBooleans as
         return t_Result;
     end;
 
+    function TestOutValueNull
+    return boolean is
+    begin
+        return null;
+    end;
+
     procedure TestOutArrays (
         a_NumElements                   number,
         a_Value                         out nocopy udt_BooleanList

tests/test_3100_boolean_var.py

@@ -1,5 +1,5 @@
 #------------------------------------------------------------------------------
-# Copyright (c) 2020, 2022, Oracle and/or its affiliates.
+# Copyright (c) 2020, 2023, Oracle and/or its affiliates.
 #
 # This software is dual-licensed to you under the Universal Permissive License
 # (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
@@ -89,5 +89,11 @@ def test_3107_bind_true(self):
                                       (True,))
         self.assertEqual(result, "TRUE")
 
+    def test_3108_bind_out_null(self):
+        "3108 - test binding out a boolean value (None)"
+        result = self.cursor.callfunc("pkg_TestBooleans.TestOutValueNull",
+                                      bool)
+        self.assertEqual(result, None)
+
 if __name__ == "__main__":
     test_env.run_test_cases()