exit from consumer batch loop when no more messages left (swift-server#153)

blindspotbounty · blindspotbounty · commit 12d1e069d1e8 · 2023-12-06T17:59:48.000+02:00
diff --git a/Sources/Kafka/KafkaConsumer.swift b/Sources/Kafka/KafkaConsumer.swift
@@ -601,9 +601,10 @@ public final class KafkaConsumer: Sendable, Service {
                 result = .failure(error)
             }
 
-            if let result {
-                messageResults.append(result)
+            guard let result else {
+                return messageResults
             }
+            messageResults.append(result)
         }
 
         return messageResults

Original file line number	Diff line number	Diff line change
`@@ -601,9 +601,10 @@ public final class KafkaConsumer: Sendable, Service {`
`601`	`601`	`result = .failure(error)`
`602`	`602`	`}`
`603`	`603`
`604`		`- if let result {`
`605`		`- messageResults.append(result)`
	`604`	`+ guard let result else {`
	`605`	`+ return messageResults`
`606`	`606`	`}`
	`607`	`+ messageResults.append(result)`
`607`	`608`	`}`
`608`	`609`
`609`	`610`	`return messageResults`