#patch: #146 allow updateSnapshot=false for legacy compatibility (#150)

jackmatt2 · web-flow · commit ddfd6ee71ebe · 2023-02-16T20:08:47.000+11:00
diff --git a/java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/config/PropertyResolvingSnapshotConfig.java b/java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/config/PropertyResolvingSnapshotConfig.java
@@ -32,6 +32,9 @@ public Optional<String> updateSnapshot() {
       LoggingHelper.deprecatedV5(
           log,
           "Passing -PupdateSnapshot will be removed in a future release. Consider using snapshot.properties 'update-snapshot' toggle instead");
+      if ("false".equals(legacyFlag.get())) {
+        return Optional.empty();
+      }
       return legacyFlag;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,9 @@ public Optional<String> updateSnapshot() {`
`32`	`32`	`LoggingHelper.deprecatedV5(`
`33`	`33`	`log,`
`34`	`34`	`"Passing -PupdateSnapshot will be removed in a future release. Consider using snapshot.properties 'update-snapshot' toggle instead");`
	`35`	`+ if ("false".equals(legacyFlag.get())) {`
	`36`	`+ return Optional.empty();`
	`37`	`+ }`
`35`	`38`	`return legacyFlag;`
`36`	`39`	`}`
`37`	`40`