-
Notifications
You must be signed in to change notification settings - Fork 11
/
Copy pathno-useless-escape.ts
214 lines (209 loc) · 7.98 KB
/
no-useless-escape.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
import type {
Character,
CharacterClass,
ExpressionCharacterClass,
} from "@eslint-community/regexpp/ast"
import type { RegExpVisitor } from "@eslint-community/regexpp/visitor"
import type { RegExpContext } from "../utils"
import {
createRule,
defineRegexpVisitor,
CP_BACK_SLASH,
CP_STAR,
CP_CLOSING_BRACKET,
CP_SLASH,
CP_CARET,
CP_DOT,
CP_DOLLAR,
CP_PLUS,
CP_QUESTION,
CP_CLOSING_BRACE,
CP_CLOSING_PAREN,
CP_OPENING_BRACE,
CP_OPENING_BRACKET,
CP_OPENING_PAREN,
CP_PIPE,
CP_MINUS,
canUnwrapped,
} from "../utils"
import { RESERVED_DOUBLE_PUNCTUATOR_CP } from "../utils/regex-syntax"
const REGEX_CHAR_CLASS_ESCAPES = new Set([
CP_BACK_SLASH, // \\
CP_CLOSING_BRACKET, // ]
CP_MINUS, // -
])
const REGEX_CLASS_SET_CHAR_CLASS_ESCAPE = new Set([
CP_BACK_SLASH, // \\
CP_SLASH, // /
CP_OPENING_BRACKET, // [
CP_CLOSING_BRACKET, // ]
CP_OPENING_BRACE, // {
CP_CLOSING_BRACE, // }
CP_PIPE, // |
CP_OPENING_PAREN, // (
CP_CLOSING_PAREN, // )
CP_MINUS, // -,
])
const REGEX_ESCAPES = new Set([
CP_BACK_SLASH, // \\
CP_SLASH, // /
CP_CARET, // ^
CP_DOT, // .
CP_DOLLAR, // $
CP_STAR, // *
CP_PLUS, // +
CP_QUESTION, // ?
CP_OPENING_BRACKET, // [
CP_CLOSING_BRACKET, // ]
CP_OPENING_BRACE, // {
CP_CLOSING_BRACE, // }
CP_PIPE, // |
CP_OPENING_PAREN, // (
CP_CLOSING_PAREN, // )
])
const POTENTIAL_ESCAPE_SEQUENCE = new Set("uxkpP")
const POTENTIAL_ESCAPE_SEQUENCE_FOR_CHAR_CLASS = new Set([
...POTENTIAL_ESCAPE_SEQUENCE,
"q",
])
export default createRule("no-useless-escape", {
meta: {
docs: {
description: "disallow unnecessary escape characters in RegExp",
category: "Stylistic Issues",
recommended: true,
},
fixable: "code",
schema: [],
messages: {
unnecessary: "Unnecessary escape character: \\{{character}}.",
},
type: "suggestion", // "problem",
},
create(context) {
function createVisitor({
node,
flags,
pattern,
getRegexpLocation,
fixReplaceNode,
}: RegExpContext): RegExpVisitor.Handlers {
function report(
cNode: Character,
offset: number,
character: string,
fix: boolean,
) {
context.report({
node,
loc: getRegexpLocation(cNode, [offset, offset + 1]),
messageId: "unnecessary",
data: {
character,
},
fix: fix ? fixReplaceNode(cNode, character) : null,
})
}
const characterClassStack: (
| CharacterClass
| ExpressionCharacterClass
)[] = []
return {
onCharacterClassEnter: (characterClassNode) =>
characterClassStack.unshift(characterClassNode),
onCharacterClassLeave: () => characterClassStack.shift(),
onExpressionCharacterClassEnter: (characterClassNode) =>
characterClassStack.unshift(characterClassNode),
onExpressionCharacterClassLeave: () =>
characterClassStack.shift(),
onCharacterEnter(cNode) {
if (cNode.raw.startsWith("\\")) {
// escapes
const char = cNode.raw.slice(1)
const escapedChar = String.fromCodePoint(cNode.value)
if (char === escapedChar) {
let allowedEscapes: Set<number>
if (characterClassStack.length) {
allowedEscapes = flags.unicodeSets
? REGEX_CLASS_SET_CHAR_CLASS_ESCAPE
: REGEX_CHAR_CLASS_ESCAPES
} else {
allowedEscapes = REGEX_ESCAPES
}
if (allowedEscapes.has(cNode.value)) {
return
}
if (characterClassStack.length) {
const characterClassNode =
characterClassStack[0]
if (cNode.value === CP_CARET) {
if (
characterClassNode.start + 1 ===
cNode.start
) {
// e.g. /[\^]/
return
}
}
if (flags.unicodeSets) {
if (
RESERVED_DOUBLE_PUNCTUATOR_CP.has(
cNode.value,
)
) {
if (
pattern[cNode.end] === escapedChar
) {
// Escaping is valid if it is a ClassSetReservedDoublePunctuator.
return
}
const prevIndex = cNode.start - 1
if (
pattern[prevIndex] === escapedChar
) {
if (escapedChar !== "^") {
// e.g. [&\&]
// ^ // If it's the second character, it's a valid escape.
return
}
const elementStartIndex =
characterClassNode.start +
1 + // opening bracket(`[`)
(characterClassNode.negate
? 1 // `negate` caret(`^`)
: 0)
if (
elementStartIndex <= prevIndex
) {
// [^^\^], [_^\^]
// ^ ^ // If it's the second caret(`^`) character, it's a valid escape.
// But [^\^] is unnecessary escape.
return
}
}
}
}
}
if (!canUnwrapped(cNode, char)) {
return
}
report(
cNode,
0,
char,
!(
characterClassStack.length
? POTENTIAL_ESCAPE_SEQUENCE_FOR_CHAR_CLASS
: POTENTIAL_ESCAPE_SEQUENCE
).has(char),
)
}
}
},
}
}
return defineRegexpVisitor(context, {
createVisitor,
})
},
})