-
Notifications
You must be signed in to change notification settings - Fork 11
Support for v flag & update regexpp #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Fixing the type error won't be enough. refa and RAA can't deal with the v flag at all right now. I'll try to add support to both today. |
Quick update: I have implemented support for the v flag in refa and RAA. This took a lot longer than expected. It's not released yet, because I still want to test it some more. Also, while implementing this, the full scope of what we'll have to do dawned on me. We'll probably have to update all rules that interact with characters classes/sets in any way, not just the ones with type errors. |
In my opinion the The following rules currently do not have test cases for the
By the way, do you think we should add a rule to report empty string disjunctions like |
Agreed.
I think so too. Using a simple That being said, I think that this should be its own rule, and not part of |
Description
regexpp
added support for thev
flag.Since the AST has changed along with this, many Type errors have occurred. we need to fix them.
Also, some rules need to be fixed to understand the
v
flag.At least the following TS errors should be fixed.
regexp/negation
ruleregexp/no-contradiction-with-assertion
ruleregexp/no-dupe-characters-character-class
ruleregexp/no-dupe-disjunctions
ruleregexp/no-misleading-capturing-group
ruleregexp/optimal-quantifier-concatenation
ruleregexp/prefer-character-class
ruleregexp/sort-character-class-elements
ruleregexp/use-ignore-case
rulelib/utils/index.ts
lib/utils/partial-parser.ts
lib/utils/regexp-ast/case-variation.ts
lib/utils/regexp-ast/index.ts
lib/utils/regexp-ast/is-equals.ts
lib/utils/regexp-ast/simplify-quantifier.ts
The text was updated successfully, but these errors were encountered: