Improve default field resolver performance

Author: mcg-web

UPGRADE-0.13.md

@@ -0,0 +1,40 @@
+UPGRADE FROM 0.12 to 0.13
+=======================
+
+# Table of Contents
+
+- [Improve default field resolver](#improve-default-field-resolver)
+
+### Improve default field resolver
+
+Stop using internally `symfony/property-access` package
+since it was a bottleneck to performance for large schema.
+
+Array access and camelize getter are supported but isser, hasser,
+jQuery style (e.g. `last()`) and "can" property accessors
+are no more supported out-of-the-box,
+please implement a custom resolver if these accessors are needed.
+
+Globally:
+
+```yaml
+overblog_graphql:
+    definitions:
+        default_resolver: 'App\GraphQL\CustomResolver::defaultFieldResolver'
+```
+
+[see default field resolver for more details](https://webonyx.github.io/graphql-php/data-fetching/#default-field-resolver)
+
+Per Type:
+
+```yaml
+MyType:
+    type: object
+    config:
+        resolveField: 'App\GraphQL\MyTypeResolver::defaultFieldResolver'
+        fields:
+            name: {type: String}
+            email: {type: String}
+```
+
+[see default Field Resolver per type for more details](https://webonyx.github.io/graphql-php/data-fetching/#default-field-resolver-per-type)

composer.json

@@ -37,7 +37,6 @@
         "symfony/expression-language": "^4.3 || ~5.0",
         "symfony/framework-bundle": "^4.3 || ~5.0",
         "symfony/options-resolver": "^4.3 || ~5.0",
-        "symfony/property-access": "^4.3 || ~5.0",
         "webonyx/graphql-php": "^0.13.5"
     },
     "replace": {

src/Resolver/Resolver.php

@@ -5,14 +5,9 @@
 namespace Overblog\GraphQLBundle\Resolver;
 
 use GraphQL\Type\Definition\ResolveInfo;
-use Symfony\Component\PropertyAccess\PropertyAccess;
-use Symfony\Component\PropertyAccess\PropertyAccessor;
 
 class Resolver
 {
-    /** @var PropertyAccessor */
-    private static $accessor;
-
     public static function defaultResolveFn($objectOrArray, $args, $context, ResolveInfo $info)
     {
         $fieldName = $info->fieldName;
@@ -24,44 +19,34 @@ public static function defaultResolveFn($objectOrArray, $args, $context, Resolve
     public static function valueFromObjectOrArray($objectOrArray, $fieldName)
     {
         $value = null;
-        $index = \sprintf('[%s]', $fieldName);
-
-        if (self::isReadable($objectOrArray, $index)) {
-            $value = self::getAccessor()->getValue($objectOrArray, $index);
-        } elseif (\is_object($objectOrArray) && self::isReadable($objectOrArray, $fieldName)) {
-            $value = self::getAccessor()->getValue($objectOrArray, $fieldName);
+        if (\is_array($objectOrArray) && isset($objectOrArray[$fieldName])) {
+            $value = $objectOrArray[$fieldName];
+        } elseif (\is_object($objectOrArray)) {
+            if (null !== $getter = self::guessObjectMethod($objectOrArray, $fieldName, 'get')) {
+                $value = $objectOrArray->$getter();
+            } elseif (isset($objectOrArray->$fieldName)) {
+                $value = $objectOrArray->$fieldName;
+            }
         }
 
         return $value;
     }
 
     public static function setObjectOrArrayValue(&$objectOrArray, $fieldName, $value): void
     {
-        $index = \sprintf('[%s]', $fieldName);
-
-        if (self::isWritable($objectOrArray, $index)) {
-            self::getAccessor()->setValue($objectOrArray, $index, $value);
-        } elseif (\is_object($objectOrArray) && self::isWritable($objectOrArray, $fieldName)) {
-            self::getAccessor()->setValue($objectOrArray, $fieldName, $value);
+        if (\is_array($objectOrArray)) {
+            $objectOrArray[$fieldName] = $value;
+        } elseif (\is_object($objectOrArray)) {
+            $objectOrArray->$fieldName = $value;
         }
     }
 
-    private static function isReadable($objectOrArray, $indexOrProperty)
-    {
-        return self::getAccessor()->isReadable($objectOrArray, $indexOrProperty);
-    }
-
-    private static function isWritable($objectOrArray, $indexOrProperty)
-    {
-        return self::getAccessor()->isWritable($objectOrArray, $indexOrProperty);
-    }
-
-    private static function getAccessor()
+    private static function guessObjectMethod($object, string $fieldName, string $prefix): ?string
     {
-        if (null === self::$accessor) {
-            self::$accessor = PropertyAccess::createPropertyAccessor();
+        if (\is_callable([$object, $method = $prefix.\str_replace(' ', '', \ucwords(\str_replace('_', ' ', $fieldName)))])) {
+            return $method;
         }
 
-        return self::$accessor;
+        return null;
     }
 }