Skip to content

Signs not rendering in Minecraft 1.18 #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BenKennish opened this issue Dec 4, 2021 · 3 comments · Fixed by #2004
Closed

Signs not rendering in Minecraft 1.18 #2000

BenKennish opened this issue Dec 4, 2021 · 3 comments · Fixed by #2004

Comments

@BenKennish
Copy link

Signs do not appear to be appearing on my rendered world map after running genpoi after the upgrade to Minecraft 1.18. They were working previously. Player locations and player spawn points are being shown.

Running: /opt/minecraft/server/../tools/overviewer/overviewer.py --config=/opt/minecraft/server/../tools/overviewer/config.py --genpoi
2021-12-04 06:36:08  Searching renders: ['north-topleft', 'north-bottomright', 'nighttime']
2021-12-04 06:36:08  Will search 1 region sets using 9 filters
2021-12-04 06:36:08  Calling handleEntities for <RegionSet regiondir='/tmp/minecraft-world-copy-for-render/region'> with 9 filters
2021-12-04 06:36:08  Looking for entities in <RegionSet regiondir='/tmp/minecraft-world-copy-for-render/region'>...
2021-12-04 06:36:08  Buckets has 16884 entries.
2021-12-04 06:36:08  Buckets has 16919 entries.
2021-12-04 06:37:47  All the threads completed.
2021-12-04 06:37:47  Done.
2021-12-04 06:37:47  Loaded UUID cache from '/var/www/vhosts/tootpolice/minecraft/all-maps/in-progress/uuidcache.dat' with 6 entries.
2021-12-04 06:37:50  Done handling POIs
2021-12-04 06:37:50  Writing out javascript files
2021-12-04 06:37:50  Wrote UUID cache with 6 entries.
2021-12-04 06:37:50  Done

this is my signFilter in config.py...

def signFilter(poi):
    if poi['id'] == 'Sign' or poi['id'] == 'minecraft:sign':
        if poi['Text1'] or poi['Text2'] or poi['Text3'] or poi['Text4']:
            return "<br>\n".join([escape(poi['Text1']), escape(poi['Text2']), escape(poi['Text3']), escape(poi['Text4'])])

my latest generated markersDB.json contains just this with regards to sign stuff...

  "Signs71fc_4a11": {
    "created": false,
    "name": "Signs",
    "raw": []
  },
  "Signs71fc_98ed": {
    "created": false,
    "name": "Signs",
    "raw": []
  },
  "Signs71fc_b0de": {
    "created": false,
    "name": "Signs",
    "raw": []
  },
@bagobones
Copy link

Pulled from Discord 1.18 POI and Entity storage and naming may have changed.

@Mesaswah
Copy link

Mesaswah commented Dec 5, 2021

They changed the location of where this info is stored: https://minecraft.fandom.com/wiki/Entity_format
image
Also might need to check case-sensitivity for this.

For acknowledging purposes, I had overviewer read back the id's of the POI it came across. Player and PlayerSpawn were the only ones coming up:
image

For completeness' sake, the folder saves/<world>/poi might be interesting to check as well.

@jobe1986
Copy link

jobe1986 commented Dec 6, 2021

It appears for me that any non-Player entity in chunks upgraded to 1.18 are not being detected by GenPOI at all. That is Just ran the latest git head on my world and entities (beacons and end_gateways) in my spawn chunks are no longer detected by GenPOI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants