refactor: string functions (#5962)

Author: butuzov

engine/api/workflow_application.go

@@ -98,7 +98,7 @@ func (api *API) releaseApplicationWorkflowHandler() service.Handler {
 		for _, a := range workflowArtifacts {
 			for _, aToUp := range req.Artifacts {
 				if len(aToUp) > 0 {
-					ok, errRX := regexp.Match(aToUp, []byte(a.Name))
+					ok, errRX := regexp.MatchString(aToUp, a.Name)
 					if errRX != nil {
 						return sdk.WrapError(errRX, "releaseApplicationWorkflowHandler> %s is not a valid regular expression", aToUp)
 					}
@@ -148,7 +148,7 @@ func (api *API) releaseApplicationWorkflowHandler() service.Handler {
 			}
 			for _, aToUp := range req.Artifacts {
 				if len(aToUp) > 0 {
-					ok, err := regexp.Match(aToUp, []byte(artiData.Name))
+					ok, err := regexp.MatchString(aToUp, artiData.Name)
 					if err != nil {
 						return sdk.WrapError(err, "releaseApplicationWorkflowHandler> %s is not a valid regular expression", aToUp)
 					}

engine/hooks/outgoing_hooks.go

@@ -326,7 +326,7 @@ func (s *Service) doOutgoingWebHookExecution(ctx context.Context, t *sdk.TaskExe
 		return sdk.WrapError(handleError(ctx, err), "Unable to interpolate body")
 	}
 
-	req, err := http.NewRequest(method, urls, bytes.NewBuffer([]byte(body)))
+	req, err := http.NewRequest(method, urls, bytes.NewBufferString(body))
 	if err != nil {
 		return sdk.WrapError(handleError(ctx, err), "Unable to create request")
 	}

sdk/workflow.go

@@ -452,7 +452,7 @@ func (label *Label) IsValid() error {
 		}
 		label.Color = "#" + hex.EncodeToString(bytes)
 	} else {
-		if !ColorRegexp.Match([]byte(label.Color)) {
+		if !ColorRegexp.MatchString(label.Color) {
 			return WithStack(ErrIconBadFormat)
 		}
 	}

tools/os-ansible-inventory/types.go

@@ -37,16 +37,16 @@ type Filter struct {
 func (f Filter) Match(k, v string) (bool, error) {
 	switch f.Operator {
 	case "=":
-		if strings.ToUpper(k) == strings.ToUpper(f.Key) && strings.ToUpper(v) == strings.ToUpper(f.Value) {
+		if strings.EqualFold(k, f.Key) && strings.EqualFold(v, f.Value) {
 			return true, nil
 		}
 	case "~":
-		if strings.ToUpper(k) == strings.ToUpper(f.Key) {
+		if strings.EqualFold(k, f.Key) {
 			r, err := regexp.Compile(f.Value)
 			if err != nil {
 				return false, err
 			}
-			return r.Match([]byte(v)), nil
+			return r.MatchString(v), nil
 		}
 	default:
 		return false, fmt.Errorf("unsupported operator %s", f.Operator)