feat(manager-react-component): add service state badge component #15065
+143
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibs245
requested review from
a team,
anooparveti,
ghyenne,
frenautvh,
seven-amid and
oalkabouss
packages/manager-react-components/src/components/ServiceStateBadge/ServiceStateBadge.tsx
Outdated
Show resolved
Hide resolved
darsene
reviewed
Jan 23, 2025
packages/manager-react-components/src/components/ServiceStateBadge/ServiceStateBadge.spec.tsx
Outdated
Show resolved
Hide resolved
packages/manager-react-components/src/components/ServiceStateBadge/ServiceStateBadge.spec.tsx
Show resolved
Hide resolved
tibs245
force-pushed
the
feat/mrc-add-service-state-badge
branch
from
76c8b98 to
db435f1
Compare
darsene
previously approved these changes
Jan 23, 2025
stif59100
previously approved these changes
Jan 23, 2025
| @@ -0,0 +1,31 @@ | |||
| import fr_FR from '@ovh-ux/manager-common-translations/dist/@ovh-ux/manager-common-translations/service/Messages_fr_FR.json'; | |||
There was a problem hiding this comment.
this seems risky and also the tests fails because of it, is it the way we should import it ? I don't think so but I'm not sure
There was a problem hiding this comment.
I think we need build the module before test.
lionel95200x
previously approved these changes
Jan 23, 2025
Signed-off-by: Thibault Barske <[email protected]>
tibs245
dismissed stale reviews from lionel95200x, stif59100, and darsene
via
d8dc2f7
tibs245
force-pushed
the
feat/mrc-add-service-state-badge
branch
from
db435f1 to
d8dc2f7
Compare
github-actions
bot
added
the
continuous-integration
|
darsene
approved these changes
Jan 23, 2025
1 task
anooparveti
requested changes
Jan 24, 2025
| @@ -0,0 +1,31 @@ | |||
| import fr_FR from '@ovh-ux/manager-common-translations/dist/@ovh-ux/manager-common-translations/service/Messages_fr_FR.json'; | |||
There was a problem hiding this comment.
Dont import with relative paths as it is risky.
Use mock instead.
anooparveti
requested changes
Jan 28, 2025
Comment on lines
+16
to
+26
| const stateConfig: Record< | ||
| ResourceStatus, | ||
| { label: string; color: OdsBadgeColor } | ||
| > = { | ||
| active: { label: 'service_state_active', color: 'success' }, | ||
| deleted: { label: 'service_state_deleted', color: 'critical' }, | ||
| suspended: { label: 'service_state_suspended', color: 'warning' }, | ||
| toActivate: { label: 'service_state_toActivate', color: 'information' }, | ||
| toDelete: { label: 'service_state_toDelete', color: 'information' }, | ||
| toSuspend: { label: 'service_state_toSuspend', color: 'information' }, | ||
| }; |
There was a problem hiding this comment.
nitpick: You can also export the available states from the component so that developers can easily import the available state and have the typings suggest them available states and avoid misconfiguration.
Suggested change
| const stateConfig: Record< | |
| ResourceStatus, | |
| { label: string; color: OdsBadgeColor } | |
| > = { | |
| active: { label: 'service_state_active', color: 'success' }, | |
| deleted: { label: 'service_state_deleted', color: 'critical' }, | |
| suspended: { label: 'service_state_suspended', color: 'warning' }, | |
| toActivate: { label: 'service_state_toActivate', color: 'information' }, | |
| toDelete: { label: 'service_state_toDelete', color: 'information' }, | |
| toSuspend: { label: 'service_state_toSuspend', color: 'information' }, | |
| }; | |
| export const STATES: Record< | |
| ResourceStatus, | |
| { label: string; color: OdsBadgeColor } | |
| > = { | |
| ACTIVE: { label: 'service_state_active', color: 'success' }, | |
| DELETED: { label: 'service_state_deleted', color: 'critical' }, | |
| SUSPENDED: { label: 'service_state_suspended', color: 'warning' }, | |
| TO_ACTIVATE: { label: 'service_state_toActivate', color: 'information' }, | |
| TO_DELETE: { label: 'service_state_toDelete', color: 'information' }, | |
| TO_SUSPEND: { label: 'service_state_toSuspend', color: 'information' }, | |
| }; |
|
This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
Related
#15061