fix: ovh_domain_zone_record: use correct default value for ttl

Fixes #666

Signed-off-by: Romain Beuque <[email protected]>

Author: rbeuque74

ovh/resource_domain_zone_record.go

@@ -72,11 +72,11 @@ func resourceOvhDomainZoneRecord() *schema.Resource {
 			"ttl": {
 				Type:     schema.TypeInt,
 				Optional: true,
-				Default:  3600,
+				Default:  0,
 				ValidateFunc: func(val interface{}, key string) (warns []string, errs []error) {
 					v := val.(int)
-					if v < 60 {
-						errs = append(errs, fmt.Errorf("%q must be greater than or equal to 60, got: %d", key, v))
+					if v < 60 && v != 0 {
+						errs = append(errs, fmt.Errorf("%q must be either equal to 0 or, greater than or equal to 60, got: %d", key, v))
 					}
 					return
 				},

ovh/resource_domain_zone_record_test.go

@@ -124,6 +124,34 @@ func TestAccDomainZoneRecord_Basic(t *testing.T) {
 						"ovh_domain_zone_record.foobar", "ttl", "3600"),
 				),
 			},
+			{
+				Config: testAccCheckOvhDomainZoneRecordConfig_A(zone, subdomain, "192.168.0.11", 0),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckOvhDomainZoneRecordExists("ovh_domain_zone_record.foobar", &record),
+					resource.TestCheckResourceAttr(
+						"ovh_domain_zone_record.foobar", "subdomain", subdomain),
+					resource.TestCheckResourceAttr(
+						"ovh_domain_zone_record.foobar", "zone", zone),
+					resource.TestCheckResourceAttr(
+						"ovh_domain_zone_record.foobar", "target", "192.168.0.11"),
+					resource.TestCheckResourceAttr(
+						"ovh_domain_zone_record.foobar", "ttl", "0"),
+				),
+			},
+			{
+				Config: testAccCheckOvhDomainZoneRecordConfig_A_noTTL(zone, subdomain, "192.168.0.12"),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckOvhDomainZoneRecordExists("ovh_domain_zone_record.foobar", &record),
+					resource.TestCheckResourceAttr(
+						"ovh_domain_zone_record.foobar", "subdomain", subdomain),
+					resource.TestCheckResourceAttr(
+						"ovh_domain_zone_record.foobar", "zone", zone),
+					resource.TestCheckResourceAttr(
+						"ovh_domain_zone_record.foobar", "target", "192.168.0.12"),
+					resource.TestCheckResourceAttr(
+						"ovh_domain_zone_record.foobar", "ttl", "0"),
+				),
+			},
 		},
 	})
 }
@@ -312,6 +340,16 @@ resource "ovh_domain_zone_record" "foobar" {
 }`, zone, subdomain, target, ttl)
 }
 
+func testAccCheckOvhDomainZoneRecordConfig_A_noTTL(zone, subdomain, target string) string {
+	return fmt.Sprintf(`
+resource "ovh_domain_zone_record" "foobar" {
+	zone = "%s"
+	subdomain = "%s"
+	target = "%s"
+	fieldtype = "A"
+}`, zone, subdomain, target)
+}
+
 func testAccCheckOvhDomainZoneRecordConfig_CNAME(zone, subdomain, target string, ttl int) string {
 	return fmt.Sprintf(`
 resource "ovh_domain_zone_record" "foobar" {