fix(review): containing these fixes

fix unecessary new line
rename var
link to kubernetes documentation

Author: matprig

Diff for: ovh/resource_cloud_project_kube_nodepool_test.go

@@ -80,7 +80,7 @@ func testSweepCloudProjectKubeNodePool(region string) error {
 	return nil
 }
 
-var testAccCloudProjectKubeNodePoolConfigForEffectErrorTaints = `
+var testAccCloudProjectKubeNodePoolConfigEffectMissingInTaint = `
 resource "ovh_cloud_project_kube_nodepool" "pool" {
   service_name  = "xxx"
   kube_id       = "xxx"
@@ -113,7 +113,7 @@ resource "ovh_cloud_project_kube_nodepool" "pool" {
 }
 `
 
-var testAccCloudProjectKubeNodePoolConfigForKeyErrorTaints = `
+var testAccCloudProjectKubeNodePoolConfigKeyMissingInTaint = `
 resource "ovh_cloud_project_kube_nodepool" "pool" {
   service_name  = "xxx"
   kube_id       = "xxx"
@@ -146,7 +146,7 @@ resource "ovh_cloud_project_kube_nodepool" "pool" {
 }
 `
 
-var testAccCloudProjectKubeNodePoolConfigForValueNoCrashTaints = `
+var testAccCloudProjectKubeNodePoolConfigValueMissingInTaint = `
 resource "ovh_cloud_project_kube_nodepool" "pool" {
   service_name  = "xxx"
   kube_id       = "xxx"
@@ -187,7 +187,6 @@ resource "ovh_cloud_project_kube" "cluster" {
   version      = "%s"
 }
 
-
 resource "ovh_cloud_project_kube_nodepool" "pool" {
   service_name  = ovh_cloud_project_kube.cluster.service_name
   kube_id       = ovh_cloud_project_kube.cluster.id
@@ -415,7 +414,7 @@ func TestAccCloudProjectKubeNodePoolTaints(t *testing.T) {
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
-				Config:      testAccCloudProjectKubeNodePoolConfigForEffectErrorTaints,
+				Config:      testAccCloudProjectKubeNodePoolConfigEffectMissingInTaint,
 				ExpectError: effectTaintsErrorRegex,
 			},
 		},
@@ -430,7 +429,7 @@ func TestAccCloudProjectKubeNodePoolTaints(t *testing.T) {
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
-				Config:      testAccCloudProjectKubeNodePoolConfigForKeyErrorTaints,
+				Config:      testAccCloudProjectKubeNodePoolConfigKeyMissingInTaint,
 				ExpectError: keyTaintsErrorRegex,
 			},
 		},
@@ -445,7 +444,7 @@ func TestAccCloudProjectKubeNodePoolTaints(t *testing.T) {
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
-				Config:      testAccCloudProjectKubeNodePoolConfigForValueNoCrashTaints,
+				Config:      testAccCloudProjectKubeNodePoolConfigValueMissingInTaint,
 				ExpectError: valueNoCrashTaintsErrorRegex,
 			},
 		},

Diff for: ovh/types_cloud_project_kube_nodepool.go

@@ -205,7 +205,6 @@ func loadNodelPoolTemplateFromResource(i interface{}) (*CloudProjectKubeNodePool
 				}
 
 				template.Spec.Taints = append(template.Spec.Taints, taintObject)
-
 			}
 
 			// spec.unschedulable

Diff for: website/docs/r/cloud_project_kube_nodepool.html.markdown

@@ -80,7 +80,7 @@ The following arguments are supported:
         * `finalizers` - Finalizers to apply to each node. A finalizer name must be fully qualified, e.g. kubernetes.io/pv-protection , where you prefix it with hostname of your service which is related to the controller responsible for the finalizer.
         * `labels` - Labels to apply to each node
     * `spec` - Spec of each node in the pool
-        * `taints` - Taints to apply to each node
+        * `taints` - Taints to apply to each node (https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/node-v1/#NodeSpec)
           * `effect` - mandatory possible values: NoExecute, NoSchedule, PreferNoSchedule
           * `key` - mandatory
           * `value` - (Optional)