fix: Correctly marshal/unmarshal custom types when null/unknown

Author: Arthur Amstutz

ovh/resource_iploadbalancing_udp_farm_gen.go

@@ -21,17 +21,24 @@ type TfBoolValue struct {
 var _ basetypes.BoolValuable = TfBoolValue{}
 
 func (t *TfBoolValue) UnmarshalJSON(data []byte) error {
-	var v bool
+	var v *bool
 	if err := json.Unmarshal(data, &v); err != nil {
 		return err
 	}
 
-	t.BoolValue = basetypes.NewBoolValue(v)
+	if v == nil {
+		t.BoolValue = basetypes.NewBoolNull()
+	} else {
+		t.BoolValue = basetypes.NewBoolValue(*v)
+	}
 
 	return nil
 }
 
 func (t TfBoolValue) MarshalJSON() ([]byte, error) {
+	if t.IsNull() || t.IsUnknown() {
+		return []byte("null"), nil
+	}
 	return json.Marshal(t.BoolValue.ValueBool())
 }
 

ovh/resource_iploadbalancing_udp_frontend_gen.go

@@ -72,17 +72,24 @@ type TfInt64Value struct {
 var _ basetypes.Int64Valuable = TfInt64Value{}
 
 func (t *TfInt64Value) UnmarshalJSON(data []byte) error {
-	var v int64
+	var v *int64
 	if err := json.Unmarshal(data, &v); err != nil {
 		return err
 	}
 
-	t.Int64Value = basetypes.NewInt64Value(v)
+	if v == nil {
+		t.Int64Value = basetypes.NewInt64Null()
+	} else {
+		t.Int64Value = basetypes.NewInt64Value(*v)
+	}
 
 	return nil
 }
 
 func (t TfInt64Value) MarshalJSON() ([]byte, error) {
+	if t.IsNull() || t.IsUnknown() {
+		return []byte("null"), nil
+	}
 	return json.Marshal(t.Int64Value.ValueInt64())
 }
 

ovh/types/bool.go

@@ -136,19 +136,26 @@ func (t *TfListNestedValue[T]) UnmarshalJSON(data []byte) error {
 		return err
 	}
 
-	for _, c := range v {
-		d = append(d, c)
-	}
-
 	var zero T
-	t.ListValue = basetypes.NewListValueMust(zero.Type(context.Background()), d)
+
+	if v == nil {
+		t.ListValue = basetypes.NewListNull(zero.Type(context.Background()))
+	} else {
+		for _, c := range v {
+			d = append(d, c)
+		}
+		t.ListValue = basetypes.NewListValueMust(zero.Type(context.Background()), d)
+	}
 
 	return nil
 }
 
 func (t TfListNestedValue[T]) MarshalJSON() ([]byte, error) {
-	var toMarshal []T
+	if t.IsNull() || t.IsUnknown() {
+		return []byte("null"), nil
+	}
 
+	var toMarshal []T
 	for _, elem := range t.Elements() {
 		toMarshal = append(toMarshal, elem.(T))
 	}

ovh/types/int64.go

@@ -105,16 +105,32 @@ func (v *TfMapNestedValue[T]) UnmarshalJSON(data []byte) error {
 		return err
 	}
 
-	for k, v := range mm {
-		d[k] = v
-	}
-
 	var zero T
-	v.MapValue = basetypes.NewMapValueMust(zero.Type(context.Background()), d)
+	if mm == nil {
+		v.MapValue = basetypes.NewMapNull(zero.Type(context.Background()))
+	} else {
+		for k, v := range mm {
+			d[k] = v
+		}
+		v.MapValue = basetypes.NewMapValueMust(zero.Type(context.Background()), d)
+	}
 
 	return nil
 }
 
+func (t TfMapNestedValue[T]) MarshalJSON() ([]byte, error) {
+	if t.IsNull() || t.IsUnknown() {
+		return []byte("null"), nil
+	}
+
+	toMarshal := make(map[string]T)
+	for key, elem := range t.Elements() {
+		toMarshal[key] = elem.(T)
+	}
+
+	return json.Marshal(toMarshal)
+}
+
 // ToTerraformValue returns the data contained in the Map as a tftypes.Value.
 func (v TfMapNestedValue[T]) ToTerraformValue(ctx context.Context) (tftypes.Value, error) {
 

ovh/types/list.go

@@ -71,17 +71,25 @@ type TfNumberValue struct {
 var _ basetypes.NumberValuable = TfNumberValue{}
 
 func (t *TfNumberValue) UnmarshalJSON(data []byte) error {
-	var v float64
+	var v *float64
 	if err := json.Unmarshal(data, &v); err != nil {
 		return err
 	}
 
-	t.NumberValue = basetypes.NewNumberValue(big.NewFloat(v))
+	if v == nil {
+		t.NumberValue = basetypes.NewNumberNull()
+	} else {
+		t.NumberValue = basetypes.NewNumberValue(big.NewFloat(*v))
+	}
 
 	return nil
 }
 
 func (t TfNumberValue) MarshalJSON() ([]byte, error) {
+	if t.IsNull() || t.IsUnknown() {
+		return []byte("null"), nil
+	}
+
 	floatVal, _ := t.ValueBigFloat().Float64()
 	return json.Marshal(floatVal)
 }

ovh/types/map.go

@@ -21,12 +21,16 @@ type TfStringValue struct {
 var _ basetypes.StringValuable = TfStringValue{}
 
 func (t *TfStringValue) UnmarshalJSON(data []byte) error {
-	var v string
+	var v *string
 	if err := json.Unmarshal(data, &v); err != nil {
 		return err
 	}
 
-	t.StringValue = basetypes.NewStringValue(v)
+	if v == nil {
+		t.StringValue = basetypes.NewStringNull()
+	} else {
+		t.StringValue = basetypes.NewStringValue(*v)
+	}
 
 	return nil
 }