Merge pull request #397 from ovh/yomovh/zone_ttl_fix

Validate TTL in zone_record to >=60

Author: scraly

ovh/resource_domain_zone_record.go

@@ -72,6 +72,13 @@ func resourceOvhDomainZoneRecord() *schema.Resource {
 				Type:     schema.TypeInt,
 				Optional: true,
 				Default:  3600,
+				ValidateFunc: func(val interface{}, key string) (warns []string, errs []error) {
+					v := val.(int)
+					if v < 60 {
+						errs = append(errs, fmt.Errorf("%q must be greater than or equal to 60, got: %d", key, v))
+					}
+					return
+				},
 			},
 			"fieldtype": {
 				Type:     schema.TypeString,

ovh/resource_domain_zone_record_test.go

@@ -6,12 +6,14 @@ import (
 	"strconv"
 	"testing"
 
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 	"log"
+	"regexp"
 	"strings"
 	"time"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 )
 
 func init() {
@@ -103,6 +105,11 @@ func TestAccDomainZoneRecord_Basic(t *testing.T) {
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckOvhDomainZoneRecordDestroy,
 		Steps: []resource.TestStep{
+			// provider shall send an error if the TTL is less than 60
+			{
+				Config:      testAccCheckOvhDomainZoneRecordConfig_CNAME(zone, subdomain, "google.com.", 10),
+				ExpectError: regexp.MustCompile(`must be greater`),
+			},
 			{
 				Config: testAccCheckOvhDomainZoneRecordConfig_A(zone, subdomain, "192.168.0.10", 3600),
 				Check: resource.ComposeTestCheckFunc(

website/docs/r/ovh_domain_zone_record.html.markdown

@@ -31,7 +31,7 @@ The following arguments are supported:
 * `subdomain` - (Required) The name of the record
 * `target` - (Required) The value of the record
 * `fieldtype` - (Required) The type of the record
-* `ttl` - (Optional) The TTL of the record
+* `ttl` - (Optional) The TTL of the record, it shall be >= to 60.
 
 
 ## Attributes Reference