feat(resource_ovh_cloud_project_region_storage_presign): add integration test & rename resource

Signed-off-by: Arnaud SINAYS <[email protected]>

Author: Arnoways

Diff for: ovh/provider.go

@@ -139,7 +139,7 @@ func Provider() *schema.Provider {
 			"ovh_cloud_project_kube_iprestrictions":                       resourceCloudProjectKubeIpRestrictions(),
 			"ovh_cloud_project_network_private":                           resourceCloudProjectNetworkPrivate(),
 			"ovh_cloud_project_network_private_subnet":                    resourceCloudProjectNetworkPrivateSubnet(),
-			"ovh_cloud_project_storage_s3_presign":                        resourceCloudProjectStorageS3Presign(),
+			"ovh_cloud_project_region_storage_presign":                    resourceCloudProjectRegionStoragePresign(),
 			"ovh_cloud_project_user":                                      resourceCloudProjectUser(),
 			"ovh_cloud_project_user_s3_credential":                        resourceCloudProjectUserS3Credential(),
 			"ovh_cloud_project_user_s3_policy":                            resourceCloudProjectUserS3Policy(),

Diff for: ovh/resource_cloud_project_storage_s3_presign.go renamed to ovh/resource_cloud_project_region_storage_presign.go

@@ -9,9 +9,9 @@ import (
 	"time"
 )
 
-func resourceCloudProjectStorageS3Presign() *schema.Resource {
+func resourceCloudProjectRegionStoragePresign() *schema.Resource {
 	return &schema.Resource{
-		Create: resourceCloudProjectStorageS3PresignCreate,
+		Create: resourceCloudProjectRegionStoragePresignCreate,
 		Read:   schema.Noop,
 		Delete: schema.Noop,
 
@@ -70,7 +70,7 @@ func resourceCloudProjectStorageS3Presign() *schema.Resource {
 	}
 }
 
-func resourceCloudProjectStorageS3PresignCreate(d *schema.ResourceData, meta interface{}) error {
+func resourceCloudProjectRegionStoragePresignCreate(d *schema.ResourceData, meta interface{}) error {
 	config := meta.(*Config)
 	serviceName := d.Get("service_name").(string)
 	regionName := d.Get("region_name").(string)

Diff for: ovh/resource_cloud_project_region_storage_presign_test.go

@@ -0,0 +1,61 @@
+package ovh
+
+import (
+	"fmt"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"os"
+	"testing"
+)
+
+const testCloudProjectRegionStoragePresign = `
+resource "ovh_cloud_project_region_storage_presign" "presign_url" {
+  service_name = "%s"
+  region_name  = "%s"
+  name         = "%s"
+  expire       = 3600
+  method       = "GET"
+  object       = "%s"
+}
+`
+
+func testAccCheckCloudRegionStorage(t *testing.T) {
+	type cloudProjectRegionStorageResponse struct {
+		Name   string `json:"name"`
+		Region string `json:"region"`
+	}
+
+	r := cloudProjectRegionStorageResponse{}
+
+	endpoint := fmt.Sprintf("/cloud/project/%s/region/%s/storage/%s",
+		os.Getenv("OVH_CLOUD_PROJECT_SERVICE_TEST"),
+		os.Getenv("OVH_CLOUD_PROJECT_REGION_STORAGE_NAME_TEST"),
+		os.Getenv("OVH_CLOUD_PROJECT_REGION_STORAGE_BUCKET_NAME_TEST"))
+
+	err := testAccOVHClient.Get(endpoint, &r)
+	if err != nil {
+		t.Fatalf("Error: %q\n", err)
+	}
+	t.Logf("Read Storage Container %s -> name: '%s', region: '%s'", endpoint, r.Name, r.Region)
+}
+
+func TestCloudProjectRegionStoragePresign(t *testing.T) {
+	serviceName := os.Getenv("OVH_CLOUD_PROJECT_SERVICE_TEST")
+	regionName := os.Getenv("OVH_CLOUD_PROJECT_REGION_STORAGE_NAME_TEST")
+	name := os.Getenv("OVH_CLOUD_PROJECT_REGION_STORAGE_BUCKET_NAME_TEST")
+	object := os.Getenv("OVH_CLOUD_PROJECT_REGION_STORAGE_OBJECT_TEST")
+
+	config := fmt.Sprintf(testCloudProjectRegionStoragePresign, serviceName, regionName, name, object)
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheckCloud(t); testAccCheckCloudProjectExists(t); testAccCheckCloudRegionStorage(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: config,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet("ovh_cloud_project_region_storage_presign.presign_url", "url"),
+				),
+			},
+		},
+	})
+}

Diff for: website/docs/r/cloud_project_storage_s3_presign.html.markdown

@@ -1,19 +1,19 @@
 ---
 layout: "ovh"
-page_title: "OVH: cloud_project_storage_s3_presign"
-sidebar_current: "docs-ovh-resource-cloud-project-storage-s3-presign"
+page_title: "OVH: cloud_project_region_storage_presign"
+sidebar_current: "docs-ovh-resource-cloud-project-region-storage-presign"
 description: |-
   Generates a temporary presigned S3 URLs to download or upload an object.
 ---
 
-# ovh_cloud_project_storage_s3_presign
+# ovh_cloud_project_region_storage_presign
 
 Generates a temporary presigned S3 URLs to download or upload an object.
 
 ## Example Usage
 
 ```hcl
-resource "ovh_cloud_project_storage_s3_presign" "presigned_url" {
+resource "ovh_cloud_project_region_storage_presign" "presigned_url" {
   service_name = "xxxxxxxxxxxxxxxxx"
   region_name  = "GRA"
   name         = "s3-bucket-name"

Diff for: website/ovh.erb

@@ -161,7 +161,7 @@
           <a href="/docs/providers/ovh/r/cloud_project_network_private_subnet.html">ovh_cloud_project_network_private_subnet</a>
         </li>
          <li<%= sidebar_current("docs-ovh-resource-cloud-project-storage-s3-presign") %>>
-           <a href="/docs/providers/ovh/r/cloud_project_storage_s3_presign.html">ovh_cloud_project_storage_s3_presign</a>
+           <a href="/docs/providers/ovh/r/cloud_project_region_storage_presign.html">ovh_cloud_project_region_storage_presign</a>
          </li>
         <li<%= sidebar_current("docs-ovh-resource-cloud-project-user") %>>
           <a href="/docs/providers/ovh/r/cloud_project_user.html">ovh_cloud_project_user</a>