Merge pull request #804 from ovh/dev/aamstutz/allow-size-edition

fix: Allow size edition in resource ovh_cloud_project_volume

Author: amstuta

ovh/resource_cloud_project_volume.go

@@ -156,12 +156,29 @@ func (r *cloudProjectVolumeResource) Update(ctx context.Context, req resource.Up
 	endpoint := "/cloud/project/" + url.PathEscape(data.ServiceName.ValueString()) + "/volume/" + url.PathEscape(data.VolumeId.ValueString())
 	if err := r.config.OVHClient.Put(endpoint, planData.ToUpdate(), nil); err != nil {
 		resp.Diagnostics.AddError(
-			fmt.Sprintf("Error calling Post %s", endpoint),
+			fmt.Sprintf("Error calling Put %s", endpoint),
 			err.Error(),
 		)
 		return
 	}
 
+	// Check if size has been modified as updating it requires a specific call
+	if !planData.Size.Equal(data.Size) {
+		endpoint = "/cloud/project/" + url.PathEscape(data.ServiceName.ValueString()) + "/volume/" + url.PathEscape(data.VolumeId.ValueString()) + "/upsize"
+		if err := r.config.OVHClient.Post(endpoint, map[string]any{
+			"size": planData.Size.ValueInt64(),
+		}, nil); err != nil {
+			resp.Diagnostics.AddError(
+				fmt.Sprintf("Error calling Post %s", endpoint),
+				err.Error(),
+			)
+			return
+		}
+
+		// Here we need to wait for some time to make sure the size is correctly updated on backend side
+		time.Sleep(1 * time.Minute)
+	}
+
 	// Read updated resource
 	endpoint = "/cloud/project/" + url.PathEscape(data.ServiceName.ValueString()) + "/region/" + url.PathEscape(data.RegionName.ValueString()) + "/volume/" + url.PathEscape(data.VolumeId.ValueString())
 	if err := r.config.OVHClient.Get(endpoint, &responseData); err != nil {
@@ -173,6 +190,7 @@ func (r *cloudProjectVolumeResource) Update(ctx context.Context, req resource.Up
 	}
 
 	responseData.MergeWith(&planData)
+	responseData.MergeWith(&data)
 
 	// Save updated data into Terraform state
 	resp.Diagnostics.Append(resp.State.Set(ctx, &responseData)...)
@@ -183,7 +201,6 @@ func (r *cloudProjectVolumeResource) Delete(ctx context.Context, req resource.De
 
 	// Read Terraform prior state data into the model
 	resp.Diagnostics.Append(req.State.Get(ctx, &data)...)
-
 	if resp.Diagnostics.HasError() {
 		return
 	}

ovh/resource_cloud_project_volume_gen.go

@@ -34,9 +34,34 @@ func TestAccCloudProjectVolume_basic(t *testing.T) {
 					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "region_name", regionName),
 					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "service_name", serviceName),
 					resource.TestCheckResourceAttrSet("ovh_cloud_project_volume.volume", "volume_id"),
-					resource.TestCheckResourceAttrSet("ovh_cloud_project_volume.volume", "type"),
-					resource.TestCheckResourceAttrSet("ovh_cloud_project_volume.volume", "description"),
-					resource.TestCheckResourceAttrSet("ovh_cloud_project_volume.volume", "name"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "type", "classic"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "description", "test"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "name", "test"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "size", "15"),
+				),
+			},
+			{
+				Config: fmt.Sprintf(`
+					resource "ovh_cloud_project_volume" "volume"  {
+						region_name = "%s"
+						service_name = "%s"
+						description = "test_updated"
+						name = "test_updated"
+						size = 20
+						type = "classic"
+					}
+				`,
+					regionName,
+					serviceName,
+				),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "region_name", regionName),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "service_name", serviceName),
+					resource.TestCheckResourceAttrSet("ovh_cloud_project_volume.volume", "volume_id"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "type", "classic"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "description", "test_updated"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "name", "test_updated"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_volume.volume", "size", "20"),
 				),
 			},
 		},

ovh/resource_cloud_project_volume_test.go

@@ -1,5 +1,5 @@
 ---
-subcategory : "Managed update"
+subcategory : "Cloud Project"
 ---
 
 # ovh_cloud_project_volume
@@ -29,7 +29,7 @@ The following arguments are supported:
 * `region_name` - Required. A valid OVHcloud public cloud region name in which the volume will be available. Ex.: "GRA11". **Changing this value recreates the resource.**
 * `description` - A description of the volume
 * `name` - Name of the volume  
-* `size` - Size (GB) of the volume  **Changing this value recreates the resource.**
+* `size` - Size (GB) of the volume
 * `type` - Type of the volume  **Changing this value recreates the resource.**
 
 ## Attributes Reference