[FEATURE] Add firewall rule import

[0xalex88]

Description

When migrating to terraform it would be nice to import firewall rules to avoid having to delete and recreate them

Affected Resource(s) and/or Data Source(s)

• ovh_ip_firewall_rule

Potential Terraform Configuration

Something like this:

data "ovh_ip_firewall_rule" "rpc_http" {
  for_each       = data.ovh_dedicated_server.rpc_node
  ip             = each.value.ip
  ip_on_firewall = each.value.ip
  sequence       = 1
}

import {
  for_each = data.ovh_ip_firewall_rule.rpc_http
  to       = ovh_ip_firewall_rule.rpc_http[each.key]
  id       = "${each.value.ip}/${each.value.ip}/${each.value.sequence}"
}

resource "ovh_ip_firewall_rule" "rpc_http" {
  for_each         = data.ovh_dedicated_server.rpc_node
  ip               = each.value.ip
  ip_on_firewall   = each.value.ip
  sequence         = 1
  action           = "permit"
  protocol         = "tcp"
  destination_port = 80
}

Additional context

I've implemented this code in resource_ip_firewall_rule.go that worked for us:

func (r *ipFirewallRuleResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
	splits := strings.Split(req.ID, "/")
	if len(splits) < 3 {
		resp.Diagnostics.AddError("Given ID is malformed", "ID must be formatted like the following: <ip>/<ipOnFirewall>/<sequence>")
		return
	}

	ip := splits[0]
	ipOnFirewall := splits[1]
	sequence, err := strconv.ParseFloat(splits[2], 64)
	if err != nil {
		resp.Diagnostics.AddError("Given firewall sequence number is malformed", "Sequence must be a numeric value")
		return
	}

	resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("ip"), ip)...)
	resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("ip_on_firewall"), ipOnFirewall)...)
	resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("sequence"), sequence)...)
}

then I had to edit the Read function to read the DestinationPort from DestinationPortDesc (it might probably need to do the same forse sourcePort and/or other fields):

         if strings.HasPrefix(responseData.DestinationPortDesc.ValueString(), "eq ") {
		port := strings.TrimPrefix(responseData.DestinationPortDesc.ValueString(), "eq ")
		portNumber, err := (strconv.ParseInt(port, 10, 64))
		if err == nil {
			responseData.DestinationPort = ovhtypes.NewTfInt64Value(portNumber)
		}
	}

	responseData.MergeWith(&data)

[amstuta]

Hello @0xalex88, thanks for opening this issue and for your code proposal :)

We'll add this quickly !

[0xalex88]

That was quick thanks @amstuta !