Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/aamstutz/backport baremetal 1.8.0 #937

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amstuta
Copy link
Collaborator

@amstuta amstuta commented Apr 3, 2025

Description

This PR backports changes that were done in v1.8.0 on resource ovh_dedicated_server:

  • Addition of parameters to control a server reinstallation: prevent_install_on_create, prevent_install_on_import
  • Added field keep_service_after_destroy to avoid calling /terminate on the service when destroying the resource in Terraform
  • Added doc to migrate from previous versions to v2.2.0

This PR also removes import from doc of resource ovh_dedicated_server_reinstall_task.

Fixes #914 (issue)
Fixes #885 (issue)

Type of change

  • Improvement (improve existing resource(s) or datasource(s))
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@amstuta amstuta requested a review from a team as a code owner April 3, 2025 14:42
rbeuque74
rbeuque74 previously approved these changes Apr 3, 2025
mxpetit
mxpetit previously approved these changes Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants