Skip to content

Commit 9bf28fb

Browse files
alrexlzchen
alrex
andauthored
rename BaggagePropagator to W3CBaggagePropagator (open-telemetry#1663)
Co-authored-by: Leighton Chen <[email protected]>
1 parent a046518 commit 9bf28fb

File tree

6 files changed

+14
-11
lines changed

6 files changed

+14
-11
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2525
- Moving `Getter`, `Setter` and `TextMapPropagator` out of `opentelemetry.trace.propagation` and
2626
into `opentelemetry.propagators`
2727
([#1662])(https://github.com/open-telemetry/opentelemetry-python/pull/1662)
28+
- Rename `BaggagePropagator` to `W3CBaggagePropagator`
29+
([#1663])(https://github.com/open-telemetry/opentelemetry-python/pull/1663)
2830

2931
## [0.18b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v0.18b0) - 2021-02-16
3032

opentelemetry-api/setup.cfg

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ opentelemetry_tracer_provider =
5454
default_tracer_provider = opentelemetry.trace:DefaultTracerProvider
5555
opentelemetry_propagator =
5656
tracecontext = opentelemetry.trace.propagation.tracecontext:TraceContextTextMapPropagator
57-
baggage = opentelemetry.baggage.propagation:BaggagePropagator
57+
baggage = opentelemetry.baggage.propagation:W3CBaggagePropagator
5858

5959
[options.extras_require]
6060
test =

opentelemetry-api/src/opentelemetry/baggage/propagation/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from opentelemetry.propagators import textmap
2222

2323

24-
class BaggagePropagator(textmap.TextMapPropagator):
24+
class W3CBaggagePropagator(textmap.TextMapPropagator):
2525
"""Extracts and injects Baggage which is used to annotate telemetry."""
2626

2727
MAX_HEADER_LENGTH = 8192

opentelemetry-api/src/opentelemetry/propagate/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
``opentelemetry.propagators.composite.CompositeHTTPPropagator`` with 2
2626
propagators, one of type
2727
``opentelemetry.trace.propagation.tracecontext.TraceContextTextMapPropagator``
28-
and other of type ``opentelemetry.baggage.propagation.BaggagePropagator``.
28+
and other of type ``opentelemetry.baggage.propagation.W3CBaggagePropagator``.
2929
Notice that these propagator classes are defined as
3030
``opentelemetry_propagator`` entry points in the ``setup.cfg`` file of
3131
``opentelemetry``.

opentelemetry-api/tests/baggage/test_baggage_propagation.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from unittest.mock import Mock, patch
1717

1818
from opentelemetry import baggage
19-
from opentelemetry.baggage.propagation import BaggagePropagator
19+
from opentelemetry.baggage.propagation import W3CBaggagePropagator
2020
from opentelemetry.context import get_current
2121
from opentelemetry.propagators.textmap import DictGetter
2222

@@ -25,7 +25,7 @@
2525

2626
class TestBaggagePropagation(unittest.TestCase):
2727
def setUp(self):
28-
self.propagator = BaggagePropagator()
28+
self.propagator = W3CBaggagePropagator()
2929

3030
def _extract(self, header_value):
3131
"""Test helper"""
@@ -87,7 +87,7 @@ def test_invalid_header(self):
8787
self.assertEqual(self._extract(header), expected)
8888

8989
def test_header_too_long(self):
90-
long_value = "s" * (BaggagePropagator.MAX_HEADER_LENGTH + 1)
90+
long_value = "s" * (W3CBaggagePropagator.MAX_HEADER_LENGTH + 1)
9191
header = "key1={}".format(long_value)
9292
expected = {}
9393
self.assertEqual(self._extract(header), expected)
@@ -96,15 +96,15 @@ def test_header_contains_too_many_entries(self):
9696
header = ",".join(
9797
[
9898
"key{}=val".format(k)
99-
for k in range(BaggagePropagator.MAX_PAIRS + 1)
99+
for k in range(W3CBaggagePropagator.MAX_PAIRS + 1)
100100
]
101101
)
102102
self.assertEqual(
103-
len(self._extract(header)), BaggagePropagator.MAX_PAIRS
103+
len(self._extract(header)), W3CBaggagePropagator.MAX_PAIRS
104104
)
105105

106106
def test_header_contains_pair_too_long(self):
107-
long_value = "s" * (BaggagePropagator.MAX_PAIR_LENGTH + 1)
107+
long_value = "s" * (W3CBaggagePropagator.MAX_PAIR_LENGTH + 1)
108108
header = "key1=value1,key2={},key3=value3".format(long_value)
109109
expected = {"key1": "value1", "key3": "value3"}
110110
self.assertEqual(self._extract(header), expected)

opentelemetry-api/tests/propagators/test_propagators.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from unittest import TestCase
1818
from unittest.mock import Mock, patch
1919

20-
from opentelemetry.baggage.propagation import BaggagePropagator
20+
from opentelemetry.baggage.propagation import W3CBaggagePropagator
2121
from opentelemetry.environment_variables import OTEL_PROPAGATORS
2222
from opentelemetry.trace.propagation.tracecontext import (
2323
TraceContextTextMapPropagator,
@@ -33,7 +33,8 @@ def test_propagators(propagators):
3333

3434
self.assertEqual(len(propagators), 2)
3535
self.assertEqual(
36-
propagators, {TraceContextTextMapPropagator, BaggagePropagator}
36+
propagators,
37+
{TraceContextTextMapPropagator, W3CBaggagePropagator},
3738
)
3839

3940
mock_compositehttppropagator.configure_mock(

0 commit comments

Comments
 (0)