Skip to content

Print ModSecurity version from nginx connector #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theseion opened this issue Apr 9, 2024 · 4 comments
Closed

Print ModSecurity version from nginx connector #316

theseion opened this issue Apr 9, 2024 · 4 comments
Assignees

Comments

@theseion
Copy link

theseion commented Apr 9, 2024

With the nginx connector (v3), the log output currently looks like this:

2024/04/04 16:11:33 [notice] 630#630: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/824/0)
2024/04/04 16:11:37 [notice] 1#1: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/824/0)
2024/04/04 16:11:37 [notice] 1#1: using the "epoll" event method
2024/04/04 16:11:37 [notice] 1#1: nginx/1.25.3
2024/04/04 16:11:37 [notice] 1#1: built by gcc 12.2.0 (Debian 12.2.0-14) 
2024/04/04 16:11:37 [notice] 1#1: OS: Linux 6.1.0-18-amd64

It would be helpful to also log the ModSecurity version, not only the connector version.

@airween
Copy link
Member

airween commented Apr 9, 2024

Thanks, I think that's a really useful feature request.

What do you think, what would be the better solution: make a new, separated line, or would be fine to append to the first line (before the part (rules loaded...)?

@theseion
Copy link
Author

theseion commented Apr 9, 2024

I think it's fine to append it to the same line. The ModSec and connector versions belong together anyway.
Maybe prepend it though: ModSecurity v3.0.12, ModSecurity-nginx v1.0.3....

@airween
Copy link
Member

airween commented Apr 23, 2024

Please take a review: #319.

@theseion
Copy link
Author

Fixed by #319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants