Skip to content

Commit d76c527

Browse files
committed
build/libxml.m4: Check for libxml2 via pkg-config then xml2-config
Debian is taking steps to remove xml2-config in favour of pkg-config. This means ModSecurity will build without libxml2 support by default on Debian, Ubuntu and other distributions tracking Debian packages. This patch modifies build/libxml.m4 to check for libxml2 via pkg-config, falling back to xml2-config if necessary.
1 parent 82f75dc commit d76c527

File tree

1 file changed

+41
-17
lines changed

1 file changed

+41
-17
lines changed

Diff for: build/libxml.m4

+41-17
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,7 @@ dnl Sets:
44
dnl LIBXML2_CFLAGS
55
dnl LIBXML2_LIBS
66

7-
LIBXML2_CONFIG=""
8-
LIBXML2_VERSION=""
9-
LIBXML2_CFLAGS=""
10-
LIBXML2_CPPFLAGS=""
11-
LIBXML2_LDADD=""
12-
LIBXML2_LDFLAGS=""
13-
14-
AC_DEFUN([CHECK_LIBXML2], [
15-
16-
AC_ARG_WITH(
17-
libxml,
18-
[AC_HELP_STRING([--with-libxml=PATH],[Path to libxml2 prefix or config script])],
19-
[test_paths="${with_libxml}"],
20-
[test_paths="/usr/local/libxml2 /usr/local/xml2 /usr/local/xml /usr/local /opt/libxml2 /opt/libxml /opt/xml2 /opt/xml /opt /usr"])
7+
AC_DEFUN([CHECK_XML2CONFIG], [
218
229
AC_MSG_CHECKING([for libxml2 config script])
2310
@@ -58,19 +45,56 @@ if test -n "${libxml2_path}"; then
5845
LIBXML2_LDADD="`${LIBXML2_CONFIG} --libs`"
5946
if test ! -z "${LIBXML2_LDADD}"; then AC_MSG_NOTICE(xml LDADD: $LIBXML2_LDADD); fi
6047
61-
AC_MSG_CHECKING([if libxml2 is at least v2.6.29])
62-
libxml2_min_ver=`echo 2.6.29 | awk -F. '{print (\$ 1 * 1000000) + (\$ 2 * 1000) + \$ 3}'`
48+
AC_MSG_CHECKING([if libxml2 is at least v${LIBXML2_MIN_VERSION}])
49+
libxml2_min_ver=`echo ${LIBXML2_MIN_VERSION} | awk -F. '{print (\$ 1 * 1000000) + (\$ 2 * 1000) + \$ 3}'`
6350
libxml2_ver=`echo ${LIBXML2_VERSION} | awk -F. '{print (\$ 1 * 1000000) + (\$ 2 * 1000) + \$ 3}'`
6451
if test "$libxml2_ver" -ge "$libxml2_min_ver"; then
6552
AC_MSG_RESULT([yes, $LIBXML2_VERSION])
6653
else
6754
AC_MSG_RESULT([no, $LIBXML2_VERSION])
68-
AC_MSG_ERROR([NOTE: libxml2 library must be at least 2.6.29])
55+
AC_MSG_ERROR([NOTE: libxml2 library must be at least ${LIBXML2_MIN_VERSION}])
6956
fi
7057
7158
else
7259
AC_MSG_RESULT([no])
7360
fi
61+
])
62+
63+
AC_DEFUN([CHECK_LIBXML2], [
64+
65+
AC_ARG_WITH(
66+
libxml,
67+
[AC_HELP_STRING([--with-libxml=PATH],[Path to libxml2 prefix or config script])],
68+
[test_paths="${with_libxml}"],
69+
[test_paths="/usr/local/libxml2 /usr/local/xml2 /usr/local/xml /usr/local /opt/libxml2 /opt/libxml /opt/xml2 /opt/xml /opt /usr"])
70+
71+
LIBXML2_MIN_VERSION="2.6.29"
72+
LIBXML2_PKG_NAME="libxml-2.0"
73+
LIBXML2_CONFIG=""
74+
LIBXML2_VERSION=""
75+
LIBXML2_CFLAGS=""
76+
LIBXML2_CPPFLAGS=""
77+
LIBXML2_LDADD=""
78+
LIBXML2_LDFLAGS=""
79+
80+
if test "x${with_libxml}" != "xno"; then
81+
if test -n "${PKG_CONFIG}"; then
82+
AC_MSG_CHECKING([for libxml2 >= ${LIBXML2_MIN_VERSION} via pkg-config])
83+
if `${PKG_CONFIG} --exists "${LIBXML2_PKG_NAME} >= ${LIBXML2_MIN_VERSION}"`; then
84+
LIBXML2_VERSION="`${PKG_CONFIG} --modversion ${LIBXML2_PKG_NAME}`"
85+
LIBXML2_CFLAGS="`${PKG_CONFIG} --cflags ${LIBXML2_PKG_NAME}` -DWITH_LIBXML2"
86+
LIBXML2_LDADD="`${PKG_CONFIG} --libs-only-l ${LIBXML2_PKG_NAME}`"
87+
LIBXML2_LDFLAGS="`${PKG_CONFIG} --libs-only-L --libs-only-other ${LIBXML2_PKG_NAME}`"
88+
AC_MSG_RESULT([found version ${LIBXML2_VERSION}])
89+
else
90+
AC_MSG_RESULT([not found])
91+
fi
92+
fi
93+
94+
if test -z "${LIBXML2_VERSION}"; then
95+
CHECK_XML2CONFIG
96+
fi
97+
fi
7498
7599
AC_SUBST(LIBXML2_CONFIG)
76100
AC_SUBST(LIBXML2_VERSION)

0 commit comments

Comments
 (0)