Skip to content

Add support for PCRE2 #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinhsv opened this issue Jan 5, 2022 · 2 comments · Fixed by #2719
Closed

Add support for PCRE2 #2668

martinhsv opened this issue Jan 5, 2022 · 2 comments · Fixed by #2719
Labels
3.x Related to ModSecurity version 3.x

Comments

@martinhsv
Copy link
Contributor

The legacy PCRE implementation (more recently referred to as PCRE1) is no longer being updated, with v8.45 (from June 2021) expected to be the final version.

Also, nginx has recently (nginx/1.21.5) changed to use PCRE2 by default, and this will cause problems if not using the --without-pcre2 flag when building (see owasp-modsecurity/ModSecurity-nginx#260, owasp-modsecurity/ModSecurity-nginx#261 ).

@airween
Copy link
Member

airween commented Jan 5, 2022

Is there any plan to replace? Perhaps some milestone?

@defanator
Copy link
Contributor

Thanks @martinhsv for bringing this one. From my pov, thorough testing for any memory leaks either in library or in connector should be the part of the effort. Existing hacks for PCRE1 are known to work, but I don't have any knowledge of how PCRE2 is handling memory allocations in comparison to older one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Related to ModSecurity version 3.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants