Merge pull request #53 from owncloud/code-syntax-&-style-improvements

some code syntax & style improvements

Author: koebel

tests/e2e/api/APIHelper.ts renamed to tests/e2e/api/apiHelper.ts

@@ -1,6 +1,6 @@
 import fs from 'fs'
 import { config } from '../config.js'
-import { sendRequest } from './APIHelper'
+import { sendRequest } from './apiHelper'
 
 export const apiUpload = async function ({ filename }): Promise<void> {
   const response = await sendRequest({

tests/e2e/api/apiUpload.ts

@@ -1,12 +1,12 @@
 Feature: Preview dicom image
-  As a user
-  I want to preview a DICOM file
-  so that I can preview DICOM image and its metadata
+  As a user who has a DICOM file
+  I want to preview the file
+  so that I can assure myself that it contains the right image and check its metadata
 
 
   Scenario: user previews dicom image
     Given the dicom file "MRBRAIN.dcm" has been uploaded
-    And the user "Admin" has logged in
+    And the user "admin" has logged in
     When the user previews the dicom file "MRBRAIN.dcm"
     Then the user should see the dicom file "MRBRAIN.dcm"
     And the user should see patient name "MR/BRAIN/GRASE/1024" in the VIP metadata section

tests/e2e/features/dicomViewer.feature

@@ -3,7 +3,7 @@ import { chromium } from '@playwright/test'
 import { xml2js } from 'xml-js'
 import { _ } from 'lodash'
 import { config } from './config.js'
-import { sendRequest } from './api/APIHelper'
+import { sendRequest } from './api/apiHelper'
 
 setDefaultTimeout(config.timeout * 1000)
 

tests/e2e/hooks.ts

@@ -1,7 +1,7 @@
 import util from 'util'
 import { getUser } from '../userStore'
 
-export class DicomViewer {
+export class dicomViewerPage {
   elements: Readonly<Record<string, string>> = {
     userNameSelector: '#oc-login-username',
     passwordSelector: '#oc-login-password',

tests/e2e/pageObjects/DicomViewer.ts renamed to tests/e2e/pageObjects/dicomViewerPage.ts

@@ -3,9 +3,9 @@ import { expect } from '@playwright/test'
 import util from 'util'
 import { config } from '../config.js'
 
-import { DicomViewer } from '../pageObjects/DicomViewer'
+import { dicomViewerPage } from '../pageObjects/dicomViewerPage'
 
-const dicomViewer = new DicomViewer()
+const dicomViewer = new dicomViewerPage()
 import { apiUpload } from '../api/apiUpload'
 
 Given('the user {string} has logged in', async function (user: string): Promise<void> {