From 771efbfef65e7ed7e756567e9307cc6e65321a55 Mon Sep 17 00:00:00 2001
From: Kathrin Koebel <kathrin@koebel.ch>
Date: Wed, 3 Apr 2024 15:41:22 +0545
Subject: [PATCH 1/7] remove unnecessary comments & legacy import

---
 src/helper/defaultPlugins.ts | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/helper/defaultPlugins.ts b/src/helper/defaultPlugins.ts
index de062d46..aa2106e0 100644
--- a/src/helper/defaultPlugins.ts
+++ b/src/helper/defaultPlugins.ts
@@ -1,4 +1,3 @@
-//import DesignSystem from 'design-system'
 import { createGettext } from 'vue3-gettext'
 import { h } from 'vue'
 import { abilitiesPlugin } from '@casl/vue'
@@ -51,14 +50,6 @@ export const defaultPlugins = ({
     }
   })
 
-  /*
-  TODO: check if this is needed, if so, try to fix import
-
-  if (designSystem) {
-    plugins.push(DesignSystem)
-  }
-  */
-
   if (gettext) {
     plugins.push(createGettext({ translations: {}, silent: true }))
   } else {

From e8d19a18bd7a6cc54ab3965c5b8bc119a7db75fa Mon Sep 17 00:00:00 2001
From: Kathrin Koebel <kathrin@koebel.ch>
Date: Wed, 3 Apr 2024 15:41:36 +0545
Subject: [PATCH 2/7] add scope to th

---
 src/components/MetadataSidebarTableRow.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/MetadataSidebarTableRow.vue b/src/components/MetadataSidebarTableRow.vue
index 340fa019..a1c38ce6 100644
--- a/src/components/MetadataSidebarTableRow.vue
+++ b/src/components/MetadataSidebarTableRow.vue
@@ -1,6 +1,6 @@
 <template>
   <tr class="dicom-metadata-section">
-    <th colspan="2">
+    <th colspan="2" scope="colgroup">
       <p
         class="oc-py-s oc-font-semibold dicom-metadata-section-title"
         :class="isFirstSection ? 'dicom-metadata-first-section' : ''"

From d73c5d89d2a90ee0e1bf4d548298c45817a40a87 Mon Sep 17 00:00:00 2001
From: Kathrin Koebel <kathrin@koebel.ch>
Date: Wed, 3 Apr 2024 15:42:07 +0545
Subject: [PATCH 3/7] change var to let

---
 src/App.vue | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index 17f00827..b1c92e18 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -123,7 +123,7 @@ if (navigator.hardwareConcurrency) {
   maxWebWorkers = Math.min(navigator.hardwareConcurrency, 7)
 }
 
-var config = {
+let config = {
   maxWebWorkers,
   startWebWorkersOnDemand: true,
   taskConfiguration: {
@@ -281,7 +281,7 @@ export default defineComponent({
         console.error('Error initalizing cornerstone core', e)
       }
     },
-    addWadouriPrefix(url: string) {
+    addWadouriPrefix(url: string): string {
       return 'wadouri:' + url
     },
     async fetchVipMetadataInformation(imageId) {
@@ -419,7 +419,7 @@ export default defineComponent({
         } else {
           // image information from viewport have already been added
           // storing elements in temp variable
-          var tempImageInformation = this.imageInformation
+          let tempImageInformation = this.imageInformation
           // adding image information elements from viewport (tempImageInformation) in proper order
           this.imageInformation = tempImageInformation
             .slice(0, 1)
@@ -626,7 +626,6 @@ export default defineComponent({
     },
     setRotation(newRotation) {
       this.currentImageRotation = newRotation
-      const { rotation } = this.viewport.getProperties()
       this.viewport.setProperties({ rotation: this.currentImageRotation })
       this.viewport.render()
     },

From c61298a26130a0b3c98deb9e77af77e477a2a06b Mon Sep 17 00:00:00 2001
From: Kathrin Koebel <kathrin@koebel.ch>
Date: Wed, 3 Apr 2024 15:43:51 +0545
Subject: [PATCH 4/7] remove unnecessary use of boolean literals

---
 src/helper/extractMetadata.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/helper/extractMetadata.ts b/src/helper/extractMetadata.ts
index 57425504..fcb0fba5 100644
--- a/src/helper/extractMetadata.ts
+++ b/src/helper/extractMetadata.ts
@@ -20,15 +20,15 @@ export const findDicomTagByValue = (value: string): string | undefined => {
 }
 
 export const formatDateTagChecker = (tag: string): boolean => {
-  return tag.endsWith('_formatDate') ? true : false
+  return tag.endsWith('_formatDate')
 }
 
 export const formatTimeTagChecker = (tag: string): boolean => {
-  return tag.endsWith('_formatTime') ? true : false
+  return tag.endsWith('_formatTime')
 }
 
 export const addSopTagChecker = (tag: string): boolean => {
-  return tag.endsWith('_addSOPuids') ? true : false
+  return tag.endsWith('_addSOPuids')
 }
 
 export const extractDicomMetadata = async (imageData: object, tags: string[], language = 'en') => {

From 1a12a229311c962ba5abbf836f5731ecca16cc70 Mon Sep 17 00:00:00 2001
From: Kathrin Koebel <kathrin@koebel.ch>
Date: Wed, 3 Apr 2024 15:52:37 +0545
Subject: [PATCH 5/7] simplify for loop

---
 src/helper/extractMetadata.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/helper/extractMetadata.ts b/src/helper/extractMetadata.ts
index fcb0fba5..5944e478 100644
--- a/src/helper/extractMetadata.ts
+++ b/src/helper/extractMetadata.ts
@@ -35,13 +35,13 @@ export const extractDicomMetadata = async (imageData: object, tags: string[], la
   const extractedData: { label: string; value: string }[] = []
 
   // extracting data
-  for (let i = 0; i < tags.length; ++i) {
+  for (const element of tags) {
     // check if tag contains an extension for date or time or SOP formatting
-    const isDate = formatDateTagChecker(tags[i])
-    const isTime = formatTimeTagChecker(tags[i])
-    const isSOP = addSopTagChecker(tags[i])
+    const isDate = formatDateTagChecker(element)
+    const isTime = formatTimeTagChecker(element)
+    const isSOP = addSopTagChecker(element)
 
-    let metadataLabel = tags[i]
+    let metadataLabel = element
     if (isDate || isTime || isSOP) {
       metadataLabel = metadataLabel.slice(0, -11) // cutting off the add-on (_formatDate or _formatTime or _addSOPuids) from the label
     }

From 1bf465760e1b9dfdb059daba5881d040b211a847 Mon Sep 17 00:00:00 2001
From: Kathrin Koebel <kathrin@koebel.ch>
Date: Thu, 4 Apr 2024 10:43:19 +0545
Subject: [PATCH 6/7] Apply suggestions from Prajwol's code review

Co-authored-by: Prajwol Amatya <83579989+PrajwolAmatya@users.noreply.github.com>
---
 src/helper/extractMetadata.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/helper/extractMetadata.ts b/src/helper/extractMetadata.ts
index 5944e478..f7710ee3 100644
--- a/src/helper/extractMetadata.ts
+++ b/src/helper/extractMetadata.ts
@@ -35,13 +35,13 @@ export const extractDicomMetadata = async (imageData: object, tags: string[], la
   const extractedData: { label: string; value: string }[] = []
 
   // extracting data
-  for (const element of tags) {
+  for (const tag of tags) {
     // check if tag contains an extension for date or time or SOP formatting
-    const isDate = formatDateTagChecker(element)
-    const isTime = formatTimeTagChecker(element)
-    const isSOP = addSopTagChecker(element)
+    const isDate = formatDateTagChecker(tag)
+    const isTime = formatTimeTagChecker(tag)
+    const isSOP = addSopTagChecker(tag)
 
-    let metadataLabel = element
+    let metadataLabel = tag
     if (isDate || isTime || isSOP) {
       metadataLabel = metadataLabel.slice(0, -11) // cutting off the add-on (_formatDate or _formatTime or _addSOPuids) from the label
     }

From 0f11200d91c14f3a49a8f161e37b40c23c4035da Mon Sep 17 00:00:00 2001
From: Kathrin Koebel <kathrin@koebel.ch>
Date: Thu, 4 Apr 2024 11:33:25 +0545
Subject: [PATCH 7/7] Apply more suggestions from code review

Co-authored-by: Prajwol Amatya <83579989+PrajwolAmatya@users.noreply.github.com>
---
 src/App.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index b1c92e18..c83df425 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -123,7 +123,7 @@ if (navigator.hardwareConcurrency) {
   maxWebWorkers = Math.min(navigator.hardwareConcurrency, 7)
 }
 
-let config = {
+const config = {
   maxWebWorkers,
   startWebWorkersOnDemand: true,
   taskConfiguration: {
@@ -419,7 +419,7 @@ export default defineComponent({
         } else {
           // image information from viewport have already been added
           // storing elements in temp variable
-          let tempImageInformation = this.imageInformation
+          const tempImageInformation = this.imageInformation
           // adding image information elements from viewport (tempImageInformation) in proper order
           this.imageInformation = tempImageInformation
             .slice(0, 1)