Skip to content

Commit 00903fe

Browse files
Run Docker container as current user (#1975)
Previously, mega-linter-runner ran the MegaLinter Docker image as root. Users whose files became owned by root as a consequence of this behavior will need to chown them to be owned by the appropriate user. This change only affects POSIX platforms, because process.getuid and process.getgid are only available there.
1 parent e957998 commit 00903fe

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-l
1010

1111
- New [cupcake flavor](https://oxsecurity.github.io/megalinter/beta/flavors/cupcake/#readme) with 78 instead of 108 linters
1212
- Don't add literal double quote character to filenames in mega-linter-runner ([#1942](https://github.com/oxsecurity/megalinter/issues/1942)).
13+
- Run Docker container as current user rather than root ([#1975](https://github.com/oxsecurity/megalinter/issues/1975))
1314
- Remove default npm-groovy-lint extra arguments ([#1872](https://github.com/oxsecurity/megalinter/issues/1872))
1415

1516
- Linter versions upgrades

mega-linter-runner/lib/runner.js

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ const optionsDefinition = require("./options");
44
const { spawnSync } = require("child_process");
55
const c = require("chalk");
66
const path = require("path");
7+
const { getgid, getuid } = require("process");
78
const which = require("which");
89
const fs = require("fs-extra");
910
const { MegaLinterUpgrader } = require("./upgrade");
@@ -127,6 +128,9 @@ ERROR: Docker engine has not been found on your system.
127128
if (options["containerName"]) {
128129
commandArgs.push(...["--name", options["containerName"]]);
129130
}
131+
if (getuid && getgid) {
132+
commandArgs.push(...["--user", `${getuid()}:${getgid()}`]);
133+
}
130134
commandArgs.push(...["-v", "/var/run/docker.sock:/var/run/docker.sock:rw"]);
131135
commandArgs.push(...["-v", `${lintPath}:/tmp/lint:rw`]);
132136
if (options.fix === true) {

0 commit comments

Comments
 (0)