Skip to content

Commit f640aea

Browse files
ngzhianCommit Bot
authored and
Commit Bot
committed
[clang-tidy] Remove user-defined destructor
This started as fixing a clang-tidy warning to use a explicitly defaulted destructor, see https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. But we can clean it up a bit more to omit the destructor, since the all its members are trivially destructible. With this change, ByteData is now is_trivially_destructible. Bug: v8:10488 Change-Id: If6698ce181dc8bca2a6623987039f3116a375dd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182309 Commit-Queue: Zhi An Ng <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/master@{#67686}
1 parent b0ce3df commit f640aea

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/parsing/preparse-data.h

-2
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,6 @@ class V8_EXPORT_PRIVATE PreparseDataBuilder : public ZoneObject,
134134
ByteData()
135135
: byte_data_(nullptr), index_(0), free_quarters_in_last_byte_(0) {}
136136

137-
~ByteData() {}
138-
139137
void Start(std::vector<uint8_t>* buffer);
140138
void Finalize(Zone* zone);
141139

0 commit comments

Comments
 (0)