Skip to content

Commit 41465bf

Browse files
wouterhbbonenfant
authored andcommitted
Pythonize input_type name in py_input_message (danielgtaylor#436)
Co-authored-by: konstantin <[email protected]> Co-authored-by: James Hilton-Balfe <[email protected]> Fixes danielgtaylor#427 Fixes danielgtaylor#438
1 parent 6536181 commit 41465bf

File tree

4 files changed

+26
-1
lines changed

4 files changed

+26
-1
lines changed

src/betterproto/plugin/models.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ def py_input_message(self) -> Optional[MessageCompiler]:
748748
# comparable with method.input_type
749749
for msg in self.request.all_messages:
750750
if (
751-
msg.py_name == name.replace(".", "")
751+
msg.py_name == pythonize_class_name(name.replace(".", ""))
752752
and msg.output_file.package == package
753753
):
754754
return msg

tests/inputs/config.py

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"googletypes_service_returns_googletype",
1919
"example_service",
2020
"empty_service",
21+
"service_uppercase",
2122
}
2223

2324

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
syntax = "proto3";
2+
3+
package service_uppercase;
4+
5+
message DoTHINGRequest {
6+
string name = 1;
7+
repeated string comments = 2;
8+
}
9+
10+
message DoTHINGResponse {
11+
repeated string names = 1;
12+
}
13+
14+
service Test {
15+
rpc DoThing (DoTHINGRequest) returns (DoTHINGResponse);
16+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import inspect
2+
3+
from tests.output_betterproto.service_uppercase import TestStub
4+
5+
6+
def test_parameters():
7+
sig = inspect.signature(TestStub.do_thing)
8+
assert len(sig.parameters) == 5, "Expected 5 parameters"

0 commit comments

Comments
 (0)