Skip to content

Commit 11ee222

Browse files
authored
TST: fix fillna test for PandasArray (#39361)
1 parent 27728f0 commit 11ee222

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

Diff for: pandas/tests/extension/test_numpy.py

+10-5
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,16 @@ def test_fillna_frame(self, data_missing):
351351
# Non-scalar "scalar" values.
352352
super().test_fillna_frame(data_missing)
353353

354-
@pytest.mark.skip("Invalid test")
355-
def test_fillna_fill_other(self, data):
356-
# inplace update doesn't work correctly with patched extension arrays
357-
# extract_array returns PandasArray, while dtype is a numpy dtype
358-
super().test_fillna_fill_other(data_missing)
354+
def test_fillna_fill_other(self, data_missing):
355+
# Same as the parent class test, but with PandasDtype for expected["B"]
356+
# instead of equivalent numpy dtype
357+
data = data_missing
358+
result = pd.DataFrame({"A": data, "B": [np.nan] * len(data)}).fillna({"B": 0.0})
359+
360+
expected = pd.DataFrame({"A": data, "B": [0.0] * len(result)})
361+
expected["B"] = expected["B"].astype(PandasDtype(expected["B"].dtype))
362+
363+
self.assert_frame_equal(result, expected)
359364

360365

361366
class TestReshaping(BaseNumPyTests, base.BaseReshapingTests):

0 commit comments

Comments
 (0)