Clean and remove unnecessry checks

Author: fbourgey

Diff for: pandas/core/base.py

@@ -1482,7 +1482,7 @@ def _arith_method(self, other, op):
 
         return self._construct_result(result, name=res_name, other=other)
 
-    def _construct_result(self, result, name, other=None):
+    def _construct_result(self, result, name, other):
         """
         Construct an appropriately-wrapped result from the ArrayLike result
         of an arithmetic-like operation.

Diff for: pandas/core/frame.py

@@ -8100,7 +8100,6 @@ def _align_for_op(
         left : DataFrame
         right : Any
         """
-
         left, right = self, other
 
         def to_series(right):
@@ -8200,6 +8199,7 @@ def to_series(right):
                         "`left, right = left.align(right, axis=1)` "
                         "before operating."
                     )
+
             left, right = left.align(
                 right,
                 join="outer",
@@ -8269,7 +8269,7 @@ def _flex_arith_method(
 
         return self._construct_result(new_data, other=other)
 
-    def _construct_result(self, result, other=None) -> DataFrame:
+    def _construct_result(self, result, other) -> DataFrame:
         """
         Wrap the result of an arithmetic, comparison, or logical operation.
 
@@ -8286,8 +8286,7 @@ def _construct_result(self, result, other=None) -> DataFrame:
         #  non-unique columns case
         out.columns = self.columns
         out.index = self.index
-        if not getattr(self, "attrs", None) and getattr(other, "attrs", None):
-            out = out.__finalize__(other)
+        out = out.__finalize__(other)
         return out
 
     def __divmod__(self, other) -> tuple[DataFrame, DataFrame]:

Diff for: pandas/core/indexes/base.py

@@ -7151,7 +7151,7 @@ def _logical_method(self, other, op):
         return self._construct_result(res_values, name=res_name, other=other)
 
     @final
-    def _construct_result(self, result, name, other=None):
+    def _construct_result(self, result, name, other):
         if isinstance(result, tuple):
             return (
                 Index(result[0], name=name, dtype=result[0].dtype),

Diff for: pandas/core/series.py

@@ -5938,7 +5938,7 @@ def _construct_result(
         self,
         result: ArrayLike | tuple[ArrayLike, ArrayLike],
         name: Hashable,
-        other: AnyArrayLike | DataFrame | None = None,
+        other: AnyArrayLike | DataFrame,
     ) -> Series | tuple[Series, Series]:
         """
         Construct an appropriately-labelled Series from the result of an op.
@@ -5947,7 +5947,7 @@ def _construct_result(
         ----------
         result : ndarray or ExtensionArray
         name : Label
-        other : Series, DataFrame or array-like, default None
+        other : Series, DataFrame or array-like
 
         Returns
         -------
@@ -5970,8 +5970,7 @@ def _construct_result(
         dtype = getattr(result, "dtype", None)
         out = self._constructor(result, index=self.index, dtype=dtype, copy=False)
         out = out.__finalize__(self)
-        if getattr(other, "attrs", None):
-            out.__finalize__(other)
+        out = out.__finalize__(other)
 
         # Set the result's name after __finalize__ is called because __finalize__
         #  would set it back to self.name