Skip to content

Commit 16dbeab

Browse files
takluyverwesm
authored andcommitted
Fixes so more tests pass on Python 3.
1 parent 550371d commit 16dbeab

File tree

5 files changed

+31
-23
lines changed

5 files changed

+31
-23
lines changed

Diff for: pandas/core/frame.py

+3
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,9 @@ def iteritems(self):
278278
"""Iterator over (column, series) pairs"""
279279
series = self._series
280280
return ((k, series[k]) for k in self.columns)
281+
282+
if py3compat.PY3:
283+
items = iteritems
281284

282285
def __len__(self):
283286
"""Returns length of index"""

Diff for: pandas/core/series.py

+3
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,9 @@ def iteritems(self):
419419
Lazily iterate over (index, value) tuples
420420
"""
421421
return itertools.izip(iter(self.index), iter(self))
422+
423+
if py3compat.PY3:
424+
items = iteritems
422425

423426
#----------------------------------------------------------------------
424427
# Arithmetic operators

Diff for: pandas/tests/test_frame.py

+17-17
Original file line numberDiff line numberDiff line change
@@ -2414,23 +2414,23 @@ def test_combine_first(self):
24142414
assert_frame_equal(comb, self.frame)
24152415

24162416
def test_combine_first_mixed_bug(self):
2417-
idx = Index(['a','b','c','e'])
2418-
ser1 = Series([5.0,-9.0,4.0,100.],index=idx)
2419-
ser2 = Series(['a', 'b', 'c', 'e'], index=idx)
2420-
ser3 = Series([12,4,5,97], index=idx)
2421-
2422-
frame1 = DataFrame({"col0" : ser1,
2423-
"col2" : ser2,
2424-
"col3" : ser3})
2425-
2426-
idx = Index(['a','b','c','f'])
2427-
ser1 = Series([5.0,-9.0,4.0,100.], index=idx)
2428-
ser2 = Series(['a','b','c','f'], index=idx)
2429-
ser3 = Series([12,4,5,97],index=idx)
2430-
2431-
frame2 = DataFrame({"col1" : ser1,
2432-
"col2" : ser2,
2433-
"col5" : ser3})
2417+
idx = Index(['a','b','c','e'])
2418+
ser1 = Series([5.0,-9.0,4.0,100.],index=idx)
2419+
ser2 = Series(['a', 'b', 'c', 'e'], index=idx)
2420+
ser3 = Series([12,4,5,97], index=idx)
2421+
2422+
frame1 = DataFrame({"col0" : ser1,
2423+
"col2" : ser2,
2424+
"col3" : ser3})
2425+
2426+
idx = Index(['a','b','c','f'])
2427+
ser1 = Series([5.0,-9.0,4.0,100.], index=idx)
2428+
ser2 = Series(['a','b','c','f'], index=idx)
2429+
ser3 = Series([12,4,5,97],index=idx)
2430+
2431+
frame2 = DataFrame({"col1" : ser1,
2432+
"col2" : ser2,
2433+
"col5" : ser3})
24342434

24352435

24362436
combined = frame1.combine_first(frame2)

Diff for: pandas/util/testing.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
K = 4
3232

3333
def rands(n):
34-
choices = string.letters + string.digits
34+
choices = string.ascii_letters + string.digits
3535
return ''.join([random.choice(choices) for _ in xrange(n)])
3636

3737
#-------------------------------------------------------------------------------

Diff for: setup.py

+7-5
Original file line numberDiff line numberDiff line change
@@ -295,13 +295,15 @@ def srcpath(name=None, suffix='.pyx', subdir='src'):
295295
'pandas.io',
296296
'pandas.sandbox',
297297
'pandas.stats',
298-
'pandas.util'],
299-
package_data={'pandas' : ['tests/*.py'],
300-
'pandas.io' : ['tests/*.py',
301-
'tests/*.h5',
298+
'pandas.util',
299+
'pandas.tests',
300+
'pandas.io.tests',
301+
'pandas.stats.tests',
302+
],
303+
package_data={'pandas.io' : ['tests/*.h5',
302304
'tests/*.csv',
303305
'tests/*.xls'],
304-
'pandas.stats' : ['tests/*.py']},
306+
},
305307
ext_modules=extensions,
306308
maintainer_email=MAINTAINER_EMAIL,
307309
description=DESCRIPTION,

0 commit comments

Comments
 (0)