Skip to content

Commit b3d5471

Browse files
committed
fix period-out; default to None for compat with categorical/sparse.
1 parent 15ce048 commit b3d5471

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

Diff for: pandas/core/generic.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3373,7 +3373,7 @@ def convert_objects(self, convert_dates=True, convert_numeric=False,
33733373

33743374
@Appender(_shared_docs['fillna'] % _shared_doc_kwargs)
33753375
def fillna(self, value=None, method=None, axis=None, inplace=False,
3376-
limit=None, downcast=None, errors='coerce'):
3376+
limit=None, downcast=None, errors=None):
33773377
inplace = validate_bool_kwarg(inplace, 'inplace')
33783378

33793379
if not missing.maybe_fill(self, value, errors):

Diff for: pandas/core/missing.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -626,11 +626,10 @@ def maybe_fill(obj, value, errors):
626626
"""
627627
from pandas import Series
628628
if isinstance(obj, Series):
629-
if errors == 'coerce':
629+
if errors is None or errors == 'coerce':
630630
return True
631631
else:
632-
is_period = is_period_arraylike(obj)
633-
if not valid_fill_value(value, obj.dtype, is_period=is_period):
632+
if not valid_fill_value(value, obj.dtype):
634633
if errors == 'raise':
635634
raise TypeError('"value" parameter must be compatible '
636635
'with the {0} dtype, but you passed a '

0 commit comments

Comments
 (0)