Skip to content

Commit d4d918b

Browse files
committed
Hard code default behavior. See #35967
1 parent 363865b commit d4d918b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: pandas/core/reshape/merge.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,15 @@ def _groupby_and_merge(by, on, left: "DataFrame", right: "DataFrame", merge_piec
109109
if not isinstance(by, (list, tuple)):
110110
by = [by]
111111

112-
lby = left.groupby(by, sort=False)
112+
# see pr-35967 for discussion about observed=False
113+
# this is the previous default behavior if the group is a categorical
114+
lby = left.groupby(by, sort=False, observed=False)
113115
rby: Optional[groupby.DataFrameGroupBy] = None
114116

115117
# if we can groupby the rhs
116118
# then we can get vastly better perf
117119
if all(item in right.columns for item in by):
118-
rby = right.groupby(by, sort=False)
120+
rby = right.groupby(by, sort=False, observed=False)
119121

120122
for key, lhs in lby:
121123

0 commit comments

Comments
 (0)