(x + 1) % 1 inside test_multi.py

[Mofef]

Code Sample, a copy-pastable example if possible

pandas/pandas/tests/indexes/test_multi.py

Lines 170 to 171 in 9303315

	major_labels = [(x + 1) % 3 for x in major_labels]
	minor_labels = [(x + 1) % 1 for x in minor_labels]

Problem description

I assume this is supposed to shift the labels cyclically by one. Then % 4 and % 2 should be used. Otherwise its at least weird to write (x + 1) % 1 instead of 0.

[jreback]

do you have an example where this is incorrect?

[Mofef]

No, i just wanted to raise the attention in case this is not on purpose.

[jreback]

I am still not clear on what the issue is? are you saying the test is wrong? you can certainly enhance it if you want

[gfyoung]

@jreback : @Mofef is saying that (x + 1) % 1 seems a little weird given that it always should return 0.

[jreback]

this is fine.