-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: "engine=odf" option should ask you to install pyodf instead of odf in pandas.read_excel #35948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you mean We'll need to update https://github.com/pandas-dev/pandas/blame/master/pandas/compat/_optional.py#L48-L50 to take an optional package name argument. Or we can have a dict of import names to package names and do something like install_name = install_mapping.get(name, name) and include the install name in the error message. |
Hello, I am new to the community, and I would like to work on this issue. May I take this issue? |
Please review my changes made in the commit. |
@hs2361 can you open a pull request and link to this issue |
I have opened a pull request. Please review my code, and please notify me of changes to be made. |
Location of the documentation
"pandas.read_excel"
Documentation problem
When
engine="odf"
is used andpyodf
is not installed it gives an error that you should install optional dependency odf aspip or conda install odf
. This pip/conda command fails because there's no module calledodf
. This could also be a security vulnerability if someone puts a malicious "odf" module on pypi.Suggested fix for documentation
The error should ask you to install odf using
pip or conda install pyodf
The text was updated successfully, but these errors were encountered: