Skip to content

DOC: Update color of icons for dark theme #48762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datapythonista opened this issue Sep 24, 2022 · 2 comments · Fixed by #48790
Closed

DOC: Update color of icons for dark theme #48762

datapythonista opened this issue Sep 24, 2022 · 2 comments · Fixed by #48790

Comments

@datapythonista
Copy link
Member

The color of our icons in the docs don't look good with the dark theme:

dark_theme_icons

It'd be good to edit the svg files and make the color the same as the titles for example, rgb(69, 157, 185).

In the Getting started there are couple of icons that don't look good either. For the sql, we could pick a gray that looks good with both the bright and dark themes. For the SAS we may need two images, one with black letters and one with white (the pydata sphinx theme supports having different images for each theme).

Not sure if there is any other part of the docs where images need to be updated, but would be good that docs look good with dark theme everywhere.

@lorenzovngl
Copy link
Contributor

Could I be the assignee of this issue?

@datapythonista
Copy link
Member Author

Sure, thanks for helping with this @lorenzovngl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants