-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
VOTE: Core Team Vote on Keeping/Removing pyarrow warning #57424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Option 2 |
2, I think enough feedback has been collected |
Option 1 |
1 similar comment
Option 1 |
Option 2 (Side Note: I'm not sure the size and capabilities of pyarrow-core and whether Option 1 with an updated message about the dependency would change the feedback received) |
Option 1, keep the warning |
Option 2 |
1 similar comment
Option 2 |
Option 1, retain the warning. |
Option 2 |
Option 3 (it's an annoying warning but also a major change |
Option 1 people complain about everything - it's a good warning and useful |
Option 1. |
Edit (@phofl): This is a core team vote, so please refrain from commenting here |
Option 1 |
1 similar comment
Option 1 |
Option 2 |
Not trying to sway anyone's vote, but I do think it's important to know that this is not always true. It will print if you run If you first import another module that imports pandas, you will not see the warning by default. |
You are right! (For some reason, I get a different This is probably not the place for a new option, but changing it to an I changed my vote to "Option 3" (indifferent). Option 2 doesn't make sense to me as a large percentage of "users" (downloads) is not yet using 2.2: https://www.pepy.tech/projects/pandas |
Option 2 |
Option 2 conditional on backing out making pyarrow required as per PDEP 10. |
@lithomas1 are you saying that you only support option 2 if pyarrow is no longer required? But given that we have not yet decided whether to reverse PDEP-10, does that change your vote? |
The final tally is
Since I did say this would be a majority vote, we should remove the warning for 2.2.1. Having said that, @jorisvandenbossche and I have discussed that we really don't have a process for revoking parts of a PDEP. In other words, PDEP-10 says a warning would be issued from 2.2 onwards. By removing the warning, we are changing the outcome of the PDEP via an ad-hoc voting process created to resolve this particular issue. So I'm not entirely comfortable with making this decision based on a difference of 1 vote. I'm not sure how others feel about the procedural aspect of this decision, where a simple majority determines the revocation of part of a PDEP. |
I'll make the PR to remove the warning. I didn't have time yesterday, so will put off the release until Friday. |
This'll also give us some time to think through this decision some more, in case people are getting worried about the simple majority thing. Can someone else update the PDEP? |
Closing since this already happened |
@pandas-dev/pandas-core
At the development meeting on February 14, we agreed to take a vote on whether to remove the
DeprecationWarning
aboutpyarrow
being required in version 2.2.1. We agreed that the decision about whetherpyarrow
will still be required with version 3.0 is delayed.Core team should vote below on one of these 2 options:
OPTION 1: Keep the
DeprecationWarning
in Version 2.2.1OPTION 2: Remove the
DeprecationWarning
in Version 2.2.1OPTION 3: Indifferent (equivalent to a +0 on up/down vote issues)
Voting will close at Noon Eastern Time on February 20, 2024. In the comments, choose OPTION 1 or OPTION 2 or OPTION 3. The decision will be based on which option receives the most votes. If OPTION 3 receives the most votes, then either OPTION 1 or OPTION 2 will be chosen based on which has the most votes. If both of those receive the same number of votes, I don't know what we will do!
For reference:
Current warning that users see when importing pandas in version 2.2.0:
Github issue with feedback: #54466
Github issue with discussion about not requiring
pyarrow
: #57073I'll list the reasons for keeping/removing the warning here, based on my recall of the discussion. Others can feel free to add additional reasons in the comments, or correct my memory.
Reasons for keeping the warning:
pyarrow
that we have not consideredpyarrow
in version 3.0Reasons for removing the warning:
pyarrow
are confused by the warningThe text was updated successfully, but these errors were encountered: