Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop duplicate indices #59133

Closed
wants to merge 4 commits into from
Closed

Drop duplicate indices #59133

wants to merge 4 commits into from

Conversation

Yousinator
Copy link

@Yousinator Yousinator commented Jun 28, 2024 •
edited
Loading

Tests are added but have not been run, as I get this error when I try to run them. I tried all envorment setup options but I end-up having the same error

root@92c4f0dec9a0:/home/pandas# pytest pandas/tests/frame/methods/test_drop_duplicates.py
ImportError while loading conftest '/home/pandas/pandas/conftest.py'.
pandas/__init__.py:47: in <module>
    from pandas.core.api import (
pandas/core/api.py:46: in <module>
    from pandas.core.groupby import (
pandas/core/groupby/__init__.py:1: in <module>
    from pandas.core.groupby.generic import (
pandas/core/groupby/generic.py:1418: in <module>
    class DataFrameGroupBy(GroupBy[DataFrame]):
pandas/core/groupby/generic.py:2571: in DataFrameGroupBy
    @doc(DataFrame.plot.__doc__)
E   AttributeError: type object 'DataFrame' has no attribute 'plot'

@Yousinator
Copy link
Author

Most of these tests are failing because of the same error mentioned earlier

AttributeError: type object 'DataFrame' has no attribute 'plot'

others like precommit fail from parts that I haven't edited

yuanx749
yuanx749 reviewed Jun 29, 2024
View reviewed changes
pandas/core/frame.py Outdated
-------
DataFrame or None
DataFrame with duplicates removed or None if ``inplace=True``.
def drop_duplicates(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have dedented the method drop_duplicates.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems my code decided to take a step back 😶‍🌫️
I'll get it back in line. Thanks for catching that!

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanx749 yuanx749 yuanx749 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Add paramenter index to drop_duplicates to drop duplicate indices
3 participants
@Yousinator @mroeschke @yuanx749