From d9bc62d491664f46b32a315741cafa6343f6857e Mon Sep 17 00:00:00 2001 From: Ruijing Li Date: Fri, 28 Dec 2018 21:55:45 -0800 Subject: [PATCH 1/5] Fixing issue with test_parquet passing --- pandas/tests/io/test_parquet.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pandas/tests/io/test_parquet.py b/pandas/tests/io/test_parquet.py index 5964c44a31f48..aa4f1d07a1a7a 100644 --- a/pandas/tests/io/test_parquet.py +++ b/pandas/tests/io/test_parquet.py @@ -201,7 +201,8 @@ def test_options_get_engine(fp, pa): @pytest.mark.xfail(is_platform_windows() or is_platform_mac(), - reason="reading pa metadata failing on Windows/mac") + reason="reading pa metadata failing on Windows/mac", + strict=False) def test_cross_engine_pa_fp(df_cross_compat, pa, fp): # cross-compat with differing reading/writing engines From 3a17930b441dab538972304d66c9294be510bbff Mon Sep 17 00:00:00 2001 From: Jeff Reback Date: Sat, 29 Dec 2018 09:40:11 -0500 Subject: [PATCH 2/5] add in fp and pyarrow --- ci/deps/azure-macos-35.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ci/deps/azure-macos-35.yaml b/ci/deps/azure-macos-35.yaml index 7a0c3b81ac8f9..b6dc2b3c27e8d 100644 --- a/ci/deps/azure-macos-35.yaml +++ b/ci/deps/azure-macos-35.yaml @@ -13,6 +13,8 @@ dependencies: - numexpr - numpy=1.12.0 - openpyxl=2.5.5 + - pyarrow + - fastparquet - pytables - python=3.5* - pytz From 9f7e6aa47e1924af62e1cbd2f0b84ef9bce31294 Mon Sep 17 00:00:00 2001 From: Jeff Reback Date: Sat, 29 Dec 2018 11:27:02 -0500 Subject: [PATCH 3/5] remove macosx xfail --- pandas/tests/io/test_parquet.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pandas/tests/io/test_parquet.py b/pandas/tests/io/test_parquet.py index aa4f1d07a1a7a..3c52cd66714bb 100644 --- a/pandas/tests/io/test_parquet.py +++ b/pandas/tests/io/test_parquet.py @@ -200,9 +200,8 @@ def test_options_get_engine(fp, pa): assert isinstance(get_engine('fastparquet'), FastParquetImpl) -@pytest.mark.xfail(is_platform_windows() or is_platform_mac(), - reason="reading pa metadata failing on Windows/mac", - strict=False) +@pytest.mark.xfail(is_platform_windows(), + reason="reading pa metadata failing on Windows") def test_cross_engine_pa_fp(df_cross_compat, pa, fp): # cross-compat with differing reading/writing engines From ba384ba828215cce32d883740b53b5e8f896fa32 Mon Sep 17 00:00:00 2001 From: Ruijing Li Date: Sat, 29 Dec 2018 10:50:14 -0800 Subject: [PATCH 4/5] Fix linting issue --- pandas/tests/io/test_parquet.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/io/test_parquet.py b/pandas/tests/io/test_parquet.py index 3c52cd66714bb..ad7ac1c5b4f02 100644 --- a/pandas/tests/io/test_parquet.py +++ b/pandas/tests/io/test_parquet.py @@ -8,7 +8,7 @@ import numpy as np import pandas as pd -from pandas.compat import PY3, is_platform_windows, is_platform_mac +from pandas.compat import PY3, is_platform_windows from pandas.io.parquet import (to_parquet, read_parquet, get_engine, PyArrowImpl, FastParquetImpl) from pandas.util import testing as tm From 41427a34aabaed4c1ae3bb07a99f87e4b3f1243f Mon Sep 17 00:00:00 2001 From: Ruijing Li Date: Sat, 29 Dec 2018 12:01:10 -0800 Subject: [PATCH 5/5] removing xfail completely --- pandas/tests/io/test_parquet.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pandas/tests/io/test_parquet.py b/pandas/tests/io/test_parquet.py index ad7ac1c5b4f02..e4f10de7f5b2b 100644 --- a/pandas/tests/io/test_parquet.py +++ b/pandas/tests/io/test_parquet.py @@ -8,7 +8,7 @@ import numpy as np import pandas as pd -from pandas.compat import PY3, is_platform_windows +from pandas.compat import PY3 from pandas.io.parquet import (to_parquet, read_parquet, get_engine, PyArrowImpl, FastParquetImpl) from pandas.util import testing as tm @@ -200,8 +200,6 @@ def test_options_get_engine(fp, pa): assert isinstance(get_engine('fastparquet'), FastParquetImpl) -@pytest.mark.xfail(is_platform_windows(), - reason="reading pa metadata failing on Windows") def test_cross_engine_pa_fp(df_cross_compat, pa, fp): # cross-compat with differing reading/writing engines