From c88950d88a931a1e62e85f413f760b289431fc7b Mon Sep 17 00:00:00 2001 From: s3rbane Date: Thu, 10 Oct 2019 16:21:14 -0400 Subject: [PATCH 1/2] Added note to contributing.rst file, telling users to append GH Issue Number to new tests --- doc/source/development/contributing.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/source/development/contributing.rst b/doc/source/development/contributing.rst index dc6fa3d100212..8550c2f628e9c 100644 --- a/doc/source/development/contributing.rst +++ b/doc/source/development/contributing.rst @@ -949,6 +949,8 @@ the expected correct result:: assert_frame_equal(pivoted, expected) +Please remember to add the Github Issue Number as a comment to a new test. + Transitioning to ``pytest`` ~~~~~~~~~~~~~~~~~~~~~~~~~~~ From bb2aa219e631657f49eef1100cd5c46a203caa29 Mon Sep 17 00:00:00 2001 From: s3rbane Date: Fri, 11 Oct 2019 15:23:53 -0400 Subject: [PATCH 2/2] added an example underneath the note --- doc/source/development/contributing.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/source/development/contributing.rst b/doc/source/development/contributing.rst index 8550c2f628e9c..949b6bd475319 100644 --- a/doc/source/development/contributing.rst +++ b/doc/source/development/contributing.rst @@ -950,7 +950,8 @@ the expected correct result:: assert_frame_equal(pivoted, expected) Please remember to add the Github Issue Number as a comment to a new test. - +E.g. "# brief comment, see GH#28907" + Transitioning to ``pytest`` ~~~~~~~~~~~~~~~~~~~~~~~~~~~