Skip to content

async keyword not properly highlighted in various places #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arch-mage opened this issue Aug 13, 2016 · 2 comments · Fixed by #635
Closed

async keyword not properly highlighted in various places #598

arch-mage opened this issue Aug 13, 2016 · 2 comments · Fixed by #635
Assignees

Comments

@arch-mage
Copy link

I found async keyword is not properly highlighted places. Here some which I found.

export default async function fn() {} // Got 'jsExportContainer'
export async function fn() {} // Got 'jsExportContainer'

class Class {
  async method() {}  // Got 'jsClassMethodType'
  static staticMethod = async function() {} // Got 'jsClassValue'
}

const object = {
  async method1() { }, // Got 'jsObjectMethodType'
  method2: async function() { }, // Got 'jsObjectValue'
  method3: async () => {} // Got 'jsFuncCall'
}

I think async keyword there should be highlighted as jsAsyncKeyword.

@mixedCase
Copy link
Contributor

@amadeus Voting for reopening. Bug still present for the most part. Copypasting OP's snippet gives me this: https://i.imgur.com/fifGcOp.png

@leomao
Copy link

leomao commented Mar 14, 2017

Is this issue going to be fixed?
Adding jsAsyncKeyword into jsExpression cluster can solve this.
But I am not sure if it is the correct way to solve this problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants