Skip to content

Commit 1ede078

Browse files
authored
fix(Logger): Handle interpolating stdout (#7114)
* fix(Logger): Handle interpolating stdout * Update CHANGELOG.md
1 parent 93781b2 commit 1ede078

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ ___
99
- IMPROVE: Optimize queries on classes with pointer permissions. [#7061](https://github.com/parse-community/parse-server/pull/7061). Thanks to [Pedro Diaz](https://github.com/pdiaz)
1010
- FIX: request.context for afterFind triggers. [#7078](https://github.com/parse-community/parse-server/pull/7078). Thanks to [dblythy](https://github.com/dblythy)
1111
- NEW: Added convenience method Parse.Cloud.sendEmail(...) to send email via email adapter in Cloud Code. [#7089](https://github.com/parse-community/parse-server/pull/7089). Thanks to [dblythy](https://github.com/dblythy)
12+
- FIX: Winston Logger interpolating stdout to console [#7114](https://github.com/parse-community/parse-server/pull/7114). Thanks to [dplewis](https://github.com/dplewis)
1213
- NEW: LiveQuery support for $and, $nor, $containedBy, $geoWithin, $geoIntersects queries [#7113](https://github.com/parse-community/parse-server/pull/7113). Thanks to [dplewis](https://github.com/dplewis)
1314

1415
### 4.5.0

spec/WinstonLoggerAdapter.spec.js

+11
Original file line numberDiff line numberDiff line change
@@ -258,4 +258,15 @@ describe('verbose logs', () => {
258258
const log = results.find(x => x.message === 'testing verbose logs with 123');
259259
expect(log);
260260
});
261+
262+
it('verbose logs should interpolate stdout', async () => {
263+
await reconfigureServer({ verbose: true, silent: false, logsFolder: null });
264+
spyOn(process.stdout, 'write');
265+
const winstonLoggerAdapter = new WinstonLoggerAdapter();
266+
winstonLoggerAdapter.log('verbose', 'testing verbose logs with %j', {
267+
hello: 'world',
268+
});
269+
const firstLog = process.stdout.write.calls.first().args[0];
270+
expect(firstLog).toBe('verbose: testing verbose logs with {"hello":"world"}\n');
271+
});
261272
});

src/Adapters/Logger/WinstonLogger.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function configureTransports(options) {
5252
colorize: true,
5353
name: 'console',
5454
silent,
55-
format: consoleFormat,
55+
format: format.combine(format.splat(), consoleFormat),
5656
},
5757
options
5858
);

src/LiveQuery/ParseLiveQueryServer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class ParseLiveQueryServer {
7979
// Register message handler for subscriber. When publisher get messages, it will publish message
8080
// to the subscribers and the handler will be called.
8181
this.subscriber.on('message', (channel, messageStr) => {
82-
logger.verbose('Subscribe messsage %j', messageStr);
82+
logger.verbose('Subscribe message %j', messageStr);
8383
let message;
8484
try {
8585
message = JSON.parse(messageStr);

0 commit comments

Comments
 (0)